From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28770 invoked by alias); 7 Jan 2009 09:56:14 -0000 Received: (qmail 28761 invoked by uid 22791); 7 Jan 2009 09:56:14 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Jan 2009 09:56:09 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id n079txVW023870; Wed, 7 Jan 2009 10:55:59 +0100 (CET) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id n079twBj014790; Wed, 7 Jan 2009 10:55:58 +0100 (CET) Date: Wed, 07 Jan 2009 09:56:00 -0000 Message-Id: <200901070955.n079twBj014790@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: sergiodj@br.ibm.com CC: gdb-patches@sourceware.org In-reply-to: <1231289020.2026.3.camel@miki> (message from =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= on Tue, 06 Jan 2009 22:43:38 -0200) Subject: Re: [PATCH] Improve the fetch/store of general-purpose and floating-point PowerPC registers References: <1223404355.7030.20.camel@miki> <1224184035.27672.64.camel@miki> <1231289020.2026.3.camel@miki> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00076.txt.bz2 > From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= > Date: Tue, 06 Jan 2009 22:43:38 -0200 > > Hi guys, > > Here's the new version of the patch. I've made some modifications in > order to "follow the pattern" already established in this portion of the > code. As a side effect, the code is cleaner now since it has less #ifdef > statements and uses control variables to decide if a ptrace flag is > present or not. > > Thanks to Luis Machado for his valuable comments regarding this. Hi Sergio, Do you really need those autoconf checks for PTRACE_GETREGS & friends? I don't see things like HAVE_PTRACE_GETREGS used in the code at all, which makes sense since you can just check whether PTRACE_GETREGS is defined in your code. The reason that there are some autoconf checks for PTRACE_XXX symbols is that at some point there were some (broken) versions of glibc that had the PTRACE_XXX symbols as enums, but not as #defines. But those versions predate the introduction of PTRACE_GETREGS & friends on Linux for PowerPC by almost a decade now. Th reason I'm somewhat concerned with adding new autoconf checks is that on slow systems running the autoconf checks can take quite a while.