From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Vladimir Prus <vladimir@codesourcery.com>,
Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Simplify breakpoint.c function parameters
Date: Mon, 08 Dec 2008 13:36:00 -0000 [thread overview]
Message-ID: <20081208133050.GA4283@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <20081208110536.GB3823@adacore.com> <ghiilu$rud$1@ger.gmane.org>
On Mon, 08 Dec 2008 08:34:22 +0100, Vladimir Prus wrote:
> FWIW, this sounds reasonable and safe to me.
On Mon, 08 Dec 2008 12:05:36 +0100, Joel Brobecker wrote:
> After careful review, this looks right to me.
Thanks both for the review, checked it in.
> I'm wondering if it would make sense to get rid of the loc_type field
> and compute it on the fly through a function...
I do not disagree.
Regards,
Jan
next prev parent reply other threads:[~2008-12-08 13:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-07 22:24 Jan Kratochvil
2008-12-08 7:35 ` Vladimir Prus
2008-12-08 13:36 ` Jan Kratochvil [this message]
2008-12-08 11:06 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081208133050.GA4283@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox