From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-60502-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18168 invoked by alias); 8 Dec 2008 13:36:08 -0000
Received: (qmail 18160 invoked by uid 22791); 8 Dec 2008 13:36:08 -0000
X-Spam-Check-By: sourceware.org
Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Dec 2008 13:35:30 +0000
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) 	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mB8DV4Lk007435; 	Mon, 8 Dec 2008 08:31:04 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mB8DV3ke023491; 	Mon, 8 Dec 2008 08:31:03 -0500
Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id mB8DUxTZ008872; 	Mon, 8 Dec 2008 08:31:00 -0500
Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) 	by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id mB8DUsEb006464; 	Mon, 8 Dec 2008 14:30:57 +0100
Received: (from jkratoch@localhost) 	by host0.dyn.jankratochvil.net (8.14.3/8.14.2/Submit) id mB8DUqHN006459; 	Mon, 8 Dec 2008 14:30:52 +0100
Date: Mon, 08 Dec 2008 13:36:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Vladimir Prus <vladimir@codesourcery.com>,         Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Simplify breakpoint.c function parameters
Message-ID: <20081208133050.GA4283@host0.dyn.jankratochvil.net>
References: <20081207222253.GA6749@host0.dyn.jankratochvil.net> <20081208110536.GB3823@adacore.com> <20081207222253.GA6749@host0.dyn.jankratochvil.net> <ghiilu$rud$1@ger.gmane.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081208110536.GB3823@adacore.com> <ghiilu$rud$1@ger.gmane.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-12/txt/msg00148.txt.bz2

On Mon, 08 Dec 2008 08:34:22 +0100, Vladimir Prus wrote:
> FWIW, this sounds reasonable and safe to me.

On Mon, 08 Dec 2008 12:05:36 +0100, Joel Brobecker wrote:
> After careful review, this looks right to me.

Thanks both for the review, checked it in.


> I'm wondering if it would make sense to get rid of the loc_type field
> and compute it on the fly through a function...

I do not disagree.


Regards,
Jan