From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Simplify breakpoint.c function parameters
Date: Mon, 08 Dec 2008 11:06:00 -0000 [thread overview]
Message-ID: <20081208110536.GB3823@adacore.com> (raw)
In-Reply-To: <20081207222253.GA6749@host0.dyn.jankratochvil.net>
> It fixes a small bug - update_watchpoint() for bp_watchpoint (software
> watchpoint) created breakpoint locations bp_loc_hardware_watchpoint while it
> should be bp_loc_other. But I am not aware of any (possibly negative) effect
> it had.
That's true!
> 2008-12-07 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Fix loc_type of `bp_location's created by update_watchpoint.
> * breakpoint.c (allocate_bp_location): Remove the bp_type parameter.
> Replace bp_type by bpt->type. Update prototype. All callers updated.
> (add_location_to_breakpoint): Remove the bp_type parameter.
> Replace bp_type by b->type. All callers updated.
> (set_breakpoint_location_function): Replace bptype by b->type.
After careful review, this looks right to me.
I'm wondering if it would make sense to get rid of the loc_type field
and compute it on the fly through a function...
--
Joel
prev parent reply other threads:[~2008-12-08 11:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-07 22:24 Jan Kratochvil
2008-12-08 7:35 ` Vladimir Prus
2008-12-08 13:36 ` Jan Kratochvil
2008-12-08 11:06 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081208110536.GB3823@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox