From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22455 invoked by alias); 8 Dec 2008 11:06:16 -0000 Received: (qmail 22444 invoked by uid 22791); 8 Dec 2008 11:06:16 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Dec 2008 11:05:40 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0403B2A9676; Mon, 8 Dec 2008 06:05:39 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id CMTscYrKlsuY; Mon, 8 Dec 2008 06:05:38 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C13702A9675; Mon, 8 Dec 2008 06:05:38 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id B07EBE7ACD; Mon, 8 Dec 2008 12:05:36 +0100 (CET) Date: Mon, 08 Dec 2008 11:06:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Simplify breakpoint.c function parameters Message-ID: <20081208110536.GB3823@adacore.com> References: <20081207222253.GA6749@host0.dyn.jankratochvil.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081207222253.GA6749@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00147.txt.bz2 > It fixes a small bug - update_watchpoint() for bp_watchpoint (software > watchpoint) created breakpoint locations bp_loc_hardware_watchpoint while it > should be bp_loc_other. But I am not aware of any (possibly negative) effect > it had. That's true! > 2008-12-07 Jan Kratochvil > > Fix loc_type of `bp_location's created by update_watchpoint. > * breakpoint.c (allocate_bp_location): Remove the bp_type parameter. > Replace bp_type by bpt->type. Update prototype. All callers updated. > (add_location_to_breakpoint): Remove the bp_type parameter. > Replace bp_type by b->type. All callers updated. > (set_breakpoint_location_function): Replace bptype by b->type. After careful review, this looks right to me. I'm wondering if it would make sense to get rid of the loc_type field and compute it on the fly through a function... -- Joel