From: Joel Brobecker <brobecker@adacore.com>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: Vladimir Prus <vladimir@codesourcery.com>,
gdb-patches@sources.redhat.com
Subject: Re: [RFA] Kill ptrace_ops_hack
Date: Thu, 13 Nov 2008 13:13:00 -0000 [thread overview]
Message-ID: <20081113012834.GK5112@adacore.com> (raw)
In-Reply-To: <20081113011653.GJ5112@adacore.com>
[-- Attachment #1: Type: text/plain, Size: 820 bytes --]
> As it happens, I had approved a patch that fixes exactly this,
> but that didn't get checked in:
>
> http://www.sourceware.org/ml/gdb-patches/2008-11/msg00175.html
>
> The patch is slightly more complete as it removes one reference to
> the gdbsim_ops global. I'll commit that part separately.
Humpf, in retrospect, I find that the above sounds very ungrateful.
Sorry about that, Thiago. I am in fact pleased that you fixed the
problem this fast!
I committed the following piece. It's really only very very minor,
but it still makes the code slightly cleaner, I think.
2008-11-12 Joel Brobecker <brobecker@adacore.com>
From Joel Sherrill <joel.sherrill@oarcorp.com>
* remote-sim.c (gdbsim_mourn_inferior): Use "target" parameter
instead of the "gdbsim_ops" global.
Checked in.
--
Joel
[-- Attachment #2: remote-sim.c.diff --]
[-- Type: text/plain, Size: 564 bytes --]
Index: remote-sim.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-sim.c,v
retrieving revision 1.79
diff -u -p -r1.79 remote-sim.c
--- remote-sim.c 11 Nov 2008 22:07:40 -0000 1.79
+++ remote-sim.c 13 Nov 2008 01:23:12 -0000
@@ -829,7 +829,7 @@ gdbsim_mourn_inferior (struct target_ops
printf_filtered ("gdbsim_mourn_inferior:\n");
remove_breakpoints ();
- target_mark_exited (&gdbsim_ops);
+ target_mark_exited (target);
generic_mourn_inferior ();
delete_thread_silent (remote_sim_ptid);
}
next prev parent reply other threads:[~2008-11-13 1:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 17:34 Vladimir Prus
2008-09-13 15:34 ` Daniel Jacobowitz
2008-09-18 0:57 ` Joel Brobecker
2008-11-04 10:20 ` Vladimir Prus
2008-11-05 13:32 ` Joel Brobecker
2008-11-11 22:51 ` Thiago Jung Bauermann
2008-11-13 13:05 ` Joel Brobecker
2008-11-13 13:13 ` Joel Brobecker [this message]
2008-11-13 20:33 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113012834.GK5112@adacore.com \
--to=brobecker@adacore.com \
--cc=bauerman@br.ibm.com \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox