From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19892 invoked by alias); 13 Nov 2008 01:29:32 -0000 Received: (qmail 19874 invoked by uid 22791); 13 Nov 2008 01:29:31 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 13 Nov 2008 01:28:38 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C857F2A968B; Wed, 12 Nov 2008 20:28:36 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id l6hlRVpseHYq; Wed, 12 Nov 2008 20:28:36 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 839852A966C; Wed, 12 Nov 2008 20:28:36 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 7DEFBE7ACD; Wed, 12 Nov 2008 17:28:34 -0800 (PST) Date: Thu, 13 Nov 2008 13:13:00 -0000 From: Joel Brobecker To: Thiago Jung Bauermann Cc: Vladimir Prus , gdb-patches@sources.redhat.com Subject: Re: [RFA] Kill ptrace_ops_hack Message-ID: <20081113012834.GK5112@adacore.com> References: <200808192133.34582.vladimir@codesourcery.com> <20080918005719.GB3651@adacore.com> <200811041319.57079.vladimir@codesourcery.com> <1226441389.20764.135.camel@localhost.localdomain> <20081113011653.GJ5112@adacore.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="TRYliJ5NKNqkz5bu" Content-Disposition: inline In-Reply-To: <20081113011653.GJ5112@adacore.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00261.txt.bz2 --TRYliJ5NKNqkz5bu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 820 > As it happens, I had approved a patch that fixes exactly this, > but that didn't get checked in: > > http://www.sourceware.org/ml/gdb-patches/2008-11/msg00175.html > > The patch is slightly more complete as it removes one reference to > the gdbsim_ops global. I'll commit that part separately. Humpf, in retrospect, I find that the above sounds very ungrateful. Sorry about that, Thiago. I am in fact pleased that you fixed the problem this fast! I committed the following piece. It's really only very very minor, but it still makes the code slightly cleaner, I think. 2008-11-12 Joel Brobecker From Joel Sherrill * remote-sim.c (gdbsim_mourn_inferior): Use "target" parameter instead of the "gdbsim_ops" global. Checked in. -- Joel --TRYliJ5NKNqkz5bu Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="remote-sim.c.diff" Content-length: 564 Index: remote-sim.c =================================================================== RCS file: /cvs/src/src/gdb/remote-sim.c,v retrieving revision 1.79 diff -u -p -r1.79 remote-sim.c --- remote-sim.c 11 Nov 2008 22:07:40 -0000 1.79 +++ remote-sim.c 13 Nov 2008 01:23:12 -0000 @@ -829,7 +829,7 @@ gdbsim_mourn_inferior (struct target_ops printf_filtered ("gdbsim_mourn_inferior:\n"); remove_breakpoints (); - target_mark_exited (&gdbsim_ops); + target_mark_exited (target); generic_mourn_inferior (); delete_thread_silent (remote_sim_ptid); } --TRYliJ5NKNqkz5bu--