From: Joel Brobecker <brobecker@adacore.com>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Kill ptrace_ops_hack
Date: Thu, 18 Sep 2008 00:57:00 -0000 [thread overview]
Message-ID: <20080918005719.GB3651@adacore.com> (raw)
In-Reply-To: <200808192133.34582.vladimir@codesourcery.com>
Looks like the following patch was approved, but hasn't been checked in.
>
> * target.h (struct target_ops): Make to_attach, to_detach,
> to_create_inferior and to_mourn_inferior accept a pointer
> to struct target_ops.
> (target_attach, target_create_inferior, target_create_inferior):
> Convert from macros to function. Find the right target to
> invoke a method of.
> (find_default_attach, find_default_create_inferior): New parameter
> ops.
> * corefile.c (core_file_command): Pass target to to_detach.
> * corelow.c (core_detach): Add 'ops' parameter.
> * fork-child.c (fork_inferior): Return the pid. Allow
> init_trace_fun to be NULL.
> * inf-ptrace (ptrace_ops_hack): Remove.
> (inf_ptrace_him): Remove, moving all logic into....
> (inf_ptrace_create_inferior): ... here. Push the target
> passed as parameter.
Just noticed a minor thing:
- push_target (ptrace_ops_hack);
+ int pid = fork_inferior (exec_file, allargs, env, inf_ptrace_me, NULL,
+ NULL, NULL);
+
+ push_target (ops);
Mark mentioned that he would prefer to have:
int pid;
pid = fork_inferior (...)
I have been hoping to contribute a couple of things, which include
thread support on Tru64. Hopefully I will get to that soon, and if
I beat to checking my patch in, you'll have to fix one extra file
(just teasing you :-).
--
Joel
next prev parent reply other threads:[~2008-09-18 0:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 17:34 Vladimir Prus
2008-09-13 15:34 ` Daniel Jacobowitz
2008-09-18 0:57 ` Joel Brobecker [this message]
2008-11-04 10:20 ` Vladimir Prus
2008-11-05 13:32 ` Joel Brobecker
2008-11-11 22:51 ` Thiago Jung Bauermann
2008-11-13 13:05 ` Joel Brobecker
2008-11-13 13:13 ` Joel Brobecker
2008-11-13 20:33 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080918005719.GB3651@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox