From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30702 invoked by alias); 18 Sep 2008 00:57:58 -0000 Received: (qmail 30693 invoked by uid 22791); 18 Sep 2008 00:57:58 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 18 Sep 2008 00:57:23 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 961B02A96B4; Wed, 17 Sep 2008 20:57:21 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id sqURws6653Tk; Wed, 17 Sep 2008 20:57:21 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5084D2A96AA; Wed, 17 Sep 2008 20:57:21 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 193B7E7ACD; Wed, 17 Sep 2008 17:57:19 -0700 (PDT) Date: Thu, 18 Sep 2008 00:57:00 -0000 From: Joel Brobecker To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Kill ptrace_ops_hack Message-ID: <20080918005719.GB3651@adacore.com> References: <200808192133.34582.vladimir@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200808192133.34582.vladimir@codesourcery.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00380.txt.bz2 Looks like the following patch was approved, but hasn't been checked in. > > * target.h (struct target_ops): Make to_attach, to_detach, > to_create_inferior and to_mourn_inferior accept a pointer > to struct target_ops. > (target_attach, target_create_inferior, target_create_inferior): > Convert from macros to function. Find the right target to > invoke a method of. > (find_default_attach, find_default_create_inferior): New parameter > ops. > * corefile.c (core_file_command): Pass target to to_detach. > * corelow.c (core_detach): Add 'ops' parameter. > * fork-child.c (fork_inferior): Return the pid. Allow > init_trace_fun to be NULL. > * inf-ptrace (ptrace_ops_hack): Remove. > (inf_ptrace_him): Remove, moving all logic into.... > (inf_ptrace_create_inferior): ... here. Push the target > passed as parameter. Just noticed a minor thing: - push_target (ptrace_ops_hack); + int pid = fork_inferior (exec_file, allargs, env, inf_ptrace_me, NULL, + NULL, NULL); + + push_target (ops); Mark mentioned that he would prefer to have: int pid; pid = fork_inferior (...) I have been hoping to contribute a couple of things, which include thread support on Tru64. Hopefully I will get to that soon, and if I beat to checking my patch in, you'll have to fix one extra file (just teasing you :-). -- Joel