From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] Kill ptrace_ops_hack
Date: Tue, 11 Nov 2008 22:51:00 -0000 [thread overview]
Message-ID: <1226441389.20764.135.camel@localhost.localdomain> (raw)
In-Reply-To: <200811041319.57079.vladimir@codesourcery.com>
Hi,
El mar, 04-11-2008 a las 13:19 +0300, Vladimir Prus escribió:
> * target.h (struct target_ops): Make to_attach, to_detach,
> to_create_inferior and to_mourn_inferior accept a pointer
> to struct target_ops.
This patch missed functions in remote-sim.c, giving the following
warning with GCC 4.1.2:
cc1: warnings being treated as errors
/home/bauermann/scratchpad/python/gdb.git/gdb/remote-sim.c: In function âinit_gdbsim_opsâ:
/home/bauermann/scratchpad/python/gdb.git/gdb/remote-sim.c:918: warning: assignment from incompatible pointer type
/home/bauermann/scratchpad/python/gdb.git/gdb/remote-sim.c:919: warning: assignment from incompatible pointer type
GCC 4.3.2 doesn't complain, though.
Committed the following as obvious.
--
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center
2008-11-11 Thiago Jung Bauermann <bauerman@br.ibm.com>
* remote-sim.c (gdbsim_create_inferior, gdbsim_mourn_inferior): Add
missing struct target_ops argument.
Index: gdb.git/gdb/remote-sim.c
===================================================================
--- gdb.git.orig/gdb/remote-sim.c 2008-11-11 10:29:32.000000000 -0800
+++ gdb.git/gdb/remote-sim.c 2008-11-11 13:57:51.000000000 -0800
@@ -94,7 +94,7 @@
static void gdbsim_files_info (struct target_ops *target);
-static void gdbsim_mourn_inferior (void);
+static void gdbsim_mourn_inferior (struct target_ops *target);
static void gdbsim_stop (ptid_t ptid);
@@ -445,7 +445,8 @@
user types "run" after having attached. */
static void
-gdbsim_create_inferior (char *exec_file, char *args, char **env, int from_tty)
+gdbsim_create_inferior (struct target_ops *target, char *exec_file, char *args,
+ char **env, int from_tty)
{
int len;
char *arg_buf, **argv;
@@ -822,7 +823,7 @@
/* Clear the simulator's notion of what the break points are. */
static void
-gdbsim_mourn_inferior (void)
+gdbsim_mourn_inferior (struct target_ops *target)
{
if (remote_debug)
printf_filtered ("gdbsim_mourn_inferior:\n");
next prev parent reply other threads:[~2008-11-11 22:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 17:34 Vladimir Prus
2008-09-13 15:34 ` Daniel Jacobowitz
2008-09-18 0:57 ` Joel Brobecker
2008-11-04 10:20 ` Vladimir Prus
2008-11-05 13:32 ` Joel Brobecker
2008-11-11 22:51 ` Thiago Jung Bauermann [this message]
2008-11-13 13:05 ` Joel Brobecker
2008-11-13 13:13 ` Joel Brobecker
2008-11-13 20:33 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226441389.20764.135.camel@localhost.localdomain \
--to=bauerman@br.ibm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox