From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2702 invoked by alias); 11 Nov 2008 22:10:47 -0000 Received: (qmail 2605 invoked by uid 22791); 11 Nov 2008 22:10:46 -0000 X-Spam-Check-By: sourceware.org Received: from igw2.br.ibm.com (HELO igw2.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 11 Nov 2008 22:10:00 +0000 Received: from d24relay01.br.ibm.com (unknown [9.8.31.16]) by igw2.br.ibm.com (Postfix) with ESMTP id 3D06F17F435 for ; Tue, 11 Nov 2008 20:08:13 -0200 (BRDT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mABN9Y631753126 for ; Tue, 11 Nov 2008 20:09:34 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mABM9uPL024141 for ; Tue, 11 Nov 2008 20:09:57 -0200 Received: from [9.18.197.159] ([9.18.197.159]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id mABM9seA024103; Tue, 11 Nov 2008 20:09:55 -0200 Subject: Re: [RFA] Kill ptrace_ops_hack From: Thiago Jung Bauermann To: Vladimir Prus Cc: Joel Brobecker , gdb-patches@sources.redhat.com In-Reply-To: <200811041319.57079.vladimir@codesourcery.com> References: <200808192133.34582.vladimir@codesourcery.com> <20080918005719.GB3651@adacore.com> <200811041319.57079.vladimir@codesourcery.com> Content-Type: text/plain; charset=utf-8 Date: Tue, 11 Nov 2008 22:51:00 -0000 Message-Id: <1226441389.20764.135.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00217.txt.bz2 Hi, El mar, 04-11-2008 a las 13:19 +0300, Vladimir Prus escribió: > * target.h (struct target_ops): Make to_attach, to_detach, > to_create_inferior and to_mourn_inferior accept a pointer > to struct target_ops. This patch missed functions in remote-sim.c, giving the following warning with GCC 4.1.2: cc1: warnings being treated as errors /home/bauermann/scratchpad/python/gdb.git/gdb/remote-sim.c: In function ‘init_gdbsim_ops’: /home/bauermann/scratchpad/python/gdb.git/gdb/remote-sim.c:918: warning: assignment from incompatible pointer type /home/bauermann/scratchpad/python/gdb.git/gdb/remote-sim.c:919: warning: assignment from incompatible pointer type GCC 4.3.2 doesn't complain, though. Committed the following as obvious. -- []'s Thiago Jung Bauermann IBM Linux Technology Center 2008-11-11 Thiago Jung Bauermann * remote-sim.c (gdbsim_create_inferior, gdbsim_mourn_inferior): Add missing struct target_ops argument. Index: gdb.git/gdb/remote-sim.c =================================================================== --- gdb.git.orig/gdb/remote-sim.c 2008-11-11 10:29:32.000000000 -0800 +++ gdb.git/gdb/remote-sim.c 2008-11-11 13:57:51.000000000 -0800 @@ -94,7 +94,7 @@ static void gdbsim_files_info (struct target_ops *target); -static void gdbsim_mourn_inferior (void); +static void gdbsim_mourn_inferior (struct target_ops *target); static void gdbsim_stop (ptid_t ptid); @@ -445,7 +445,8 @@ user types "run" after having attached. */ static void -gdbsim_create_inferior (char *exec_file, char *args, char **env, int from_tty) +gdbsim_create_inferior (struct target_ops *target, char *exec_file, char *args, + char **env, int from_tty) { int len; char *arg_buf, **argv; @@ -822,7 +823,7 @@ /* Clear the simulator's notion of what the break points are. */ static void -gdbsim_mourn_inferior (void) +gdbsim_mourn_inferior (struct target_ops *target) { if (remote_debug) printf_filtered ("gdbsim_mourn_inferior:\n");