new pdie utility macro

new pdie utility macro

[Doug Evans]

Hi.  This is an addendum to
http://sourceware.org/ml/gdb-patches/2008-09/msg00561.html

Ok to check in?
[assuming the other patch is.  btw, ping ...]

2008-10-04  Doug Evans  <dje@google.com>

	* gdbinit.in (pdie): New macro.

Index: gdbinit.in
===================================================================
RCS file: /cvs/src/src/gdb/gdbinit.in,v
retrieving revision 1.3
diff -u -p -u -p -r1.3 gdbinit.in
--- gdbinit.in	20 Jan 2004 09:29:16 -0000	1.3
+++ gdbinit.in	4 Oct 2008 20:55:12 -0000
@@ -15,3 +15,20 @@ dir @srcdir@/../bfd
 dir @srcdir@
 dir .
 set prompt (top-gdb) 
+
+define pdie
+  if $argc == 1
+    call dump_die ($arg0, 10)
+  else
+    if $argc == 2
+      call dump_die ($arg0, $arg1)
+    else
+      printf "Syntax: pdie die [depth]\n"
+    end
+  end
+end
+
+document pdie
+Pretty print a DWARF DIE.
+Syntax: pdie die [depth]
+end

Re: new pdie utility macro

[Daniel Jacobowitz]

On Sat, Oct 04, 2008 at 02:02:46PM -0700, Doug Evans wrote:
> Hi.  This is an addendum to
> http://sourceware.org/ml/gdb-patches/2008-09/msg00561.html
> 
> Ok to check in?
> [assuming the other patch is.  btw, ping ...]
> 
> 2008-10-04  Doug Evans  <dje@google.com>
> 
> 	* gdbinit.in (pdie): New macro.

OK.

-- 
Daniel Jacobowitz
CodeSourcery

Re: new pdie utility macro

[Daniel Jacobowitz]

On Sat, Oct 04, 2008 at 02:02:46PM -0700, Doug Evans wrote:
> Hi.  This is an addendum to
> http://sourceware.org/ml/gdb-patches/2008-09/msg00561.html
> 
> Ok to check in?
> [assuming the other patch is.  btw, ping ...]

Actually, why this choice?

> +  if $argc == 1
> +    call dump_die ($arg0, 10)

I'd have guessed this as 0 instead of 10.  If I say "pdie die"
shouldn't it print the DIE, not its children?

-- 
Daniel Jacobowitz
CodeSourcery

Re: new pdie utility macro

[Doug Evans]

On Sun, Oct 5, 2008 at 9:07 AM, Daniel Jacobowitz <drow@false.org> wrote:
> On Sat, Oct 04, 2008 at 02:02:46PM -0700, Doug Evans wrote:
>> Hi.  This is an addendum to
>> http://sourceware.org/ml/gdb-patches/2008-09/msg00561.html
>>
>> Ok to check in?
>> [assuming the other patch is.  btw, ping ...]
>
> Actually, why this choice?
>
>> +  if $argc == 1
>> +    call dump_die ($arg0, 10)
>
> I'd have guessed this as 0 instead of 10.  If I say "pdie die"
> shouldn't it print the DIE, not its children?

I picked a default value that was working for me.
I'll check it in as just printing the die without children,