From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29298 invoked by alias); 5 Oct 2008 19:19:50 -0000 Received: (qmail 29289 invoked by uid 22791); 5 Oct 2008 19:19:50 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 05 Oct 2008 19:19:00 +0000 Received: from spaceape12.eur.corp.google.com (spaceape12.eur.corp.google.com [172.28.16.146]) by smtp-out.google.com with ESMTP id m95JIvQH017606 for ; Sun, 5 Oct 2008 20:18:57 +0100 Received: from rv-out-0708.google.com (rvfc5.prod.google.com [10.140.180.5]) by spaceape12.eur.corp.google.com with ESMTP id m95JIsqu028719 for ; Sun, 5 Oct 2008 12:18:55 -0700 Received: by rv-out-0708.google.com with SMTP id c5so2334954rvf.34 for ; Sun, 05 Oct 2008 12:18:54 -0700 (PDT) Received: by 10.141.13.13 with SMTP id q13mr2317881rvi.11.1223234334597; Sun, 05 Oct 2008 12:18:54 -0700 (PDT) Received: by 10.140.201.10 with HTTP; Sun, 5 Oct 2008 12:18:54 -0700 (PDT) Message-ID: Date: Sun, 05 Oct 2008 19:19:00 -0000 From: "Doug Evans" To: gdb-patches@sourceware.org Subject: Re: new pdie utility macro In-Reply-To: <20081005160743.GD29968@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20081004210246.50FE91C78FA@localhost> <20081005160743.GD29968@caradoc.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00137.txt.bz2 On Sun, Oct 5, 2008 at 9:07 AM, Daniel Jacobowitz wrote: > On Sat, Oct 04, 2008 at 02:02:46PM -0700, Doug Evans wrote: >> Hi. This is an addendum to >> http://sourceware.org/ml/gdb-patches/2008-09/msg00561.html >> >> Ok to check in? >> [assuming the other patch is. btw, ping ...] > > Actually, why this choice? > >> + if $argc == 1 >> + call dump_die ($arg0, 10) > > I'd have guessed this as 0 instead of 10. If I say "pdie die" > shouldn't it print the DIE, not its children? I picked a default value that was working for me. I'll check it in as just printing the die without children,