From: "Doug Evans" <dje@google.com>
To: gdb-patches@sourceware.org
Subject: Re: new pdie utility macro
Date: Sun, 05 Oct 2008 19:19:00 -0000 [thread overview]
Message-ID: <e394668d0810051218i51da931ara3c668155bead1a1@mail.gmail.com> (raw)
In-Reply-To: <20081005160743.GD29968@caradoc.them.org>
On Sun, Oct 5, 2008 at 9:07 AM, Daniel Jacobowitz <drow@false.org> wrote:
> On Sat, Oct 04, 2008 at 02:02:46PM -0700, Doug Evans wrote:
>> Hi. This is an addendum to
>> http://sourceware.org/ml/gdb-patches/2008-09/msg00561.html
>>
>> Ok to check in?
>> [assuming the other patch is. btw, ping ...]
>
> Actually, why this choice?
>
>> + if $argc == 1
>> + call dump_die ($arg0, 10)
>
> I'd have guessed this as 0 instead of 10. If I say "pdie die"
> shouldn't it print the DIE, not its children?
I picked a default value that was working for me.
I'll check it in as just printing the die without children,
prev parent reply other threads:[~2008-10-05 19:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-04 21:03 Doug Evans
2008-10-05 16:05 ` Daniel Jacobowitz
2008-10-05 16:08 ` Daniel Jacobowitz
2008-10-05 19:19 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e394668d0810051218i51da931ara3c668155bead1a1@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox