Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: ppluzhnikov@google.com (Paul Pluzhnikov)
To: gdb-patches@sourceware.org
Subject: [patch] Fix for failing gdb.base/mips_pro.exp under gcc-4.3.1
Date: Fri, 22 Aug 2008 00:27:00 -0000	[thread overview]
Message-ID: <20080822002653.A73DF3A67DF@localhost> (raw)

Greetings,

Gcc-4.3.1 optimizes the whole thing away:

(gdb) disas main
Dump of assembler code for function main:
0x0000000000400340 <main+0>:    mov    $0x16,%eax
0x0000000000400345 <main+5>:    retq   
End of assembler dump.

Attached patch disables inlining.

The -O2 flag was added here:

  Sun Mar 17 13:35:31 1996  Fred Fish  <fnf@cygnus.com>

        * gdb.base/mips_pro.exp: Create mips_pro.ci to get gcc_compiled
        defined, and use it to compile the test case with -O2.  The
        native compilation still uses no optimization.

I could not find *why* optimization is necessary for that test case,
so don't know if disabling inlining is the correct fix :(

--
Paul Pluzhnikov

2008-02-12  Paul Pluzhnikov  <ppluzhnikov@google.com>

	*gdb.base/mips_pro.exp: compile with gcc -fno-inline,
	lest gcc-4.3.1 optimizes the whole thing away.
	

Index: gdb.base/mips_pro.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/mips_pro.exp,v
retrieving revision 1.10
diff -u -p -u -r1.10 mips_pro.exp
--- gdb.base/mips_pro.exp	6 Aug 2008 12:52:07 -0000	1.10
+++ gdb.base/mips_pro.exp	22 Aug 2008 00:20:15 -0000
@@ -35,7 +35,8 @@ if [get_compiler_info ${binfile}] {
 # This test must be compiled with -O2 if using gcc.
 
 if { [test_compiler_info gcc-*-*] } then {
-    if  { [gdb_compile "${srcdir}/$subdir/${srcfile}" "${binfile}" executable {debug additional_flags=-O2}] != "" } {
+    if  { [gdb_compile "${srcdir}/$subdir/${srcfile}" "${binfile}" \
+	    executable {debug additional_flags=-O2 additional_flags=-fno-inline}] != "" } {
      untested mips_pro.exp
      return -1
     }


             reply	other threads:[~2008-08-22  0:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-22  0:27 Paul Pluzhnikov [this message]
2008-08-22  0:47 ` Michael Snyder
2008-08-29 23:34 ` Paul Pluzhnikov
2008-09-04 23:59 ` Joel Brobecker
2008-09-05  5:16   ` Paul Pluzhnikov
2008-09-05 13:59     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080822002653.A73DF3A67DF@localhost \
    --to=ppluzhnikov@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox