From: Joel Brobecker <brobecker@adacore.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix for failing gdb.base/mips_pro.exp under gcc-4.3.1
Date: Thu, 04 Sep 2008 23:59:00 -0000 [thread overview]
Message-ID: <20080904235828.GA29631@adacore.com> (raw)
In-Reply-To: <20080822002653.A73DF3A67DF@localhost>
(sorry about the delay - it looks like everyone was very very busy
this summer)
> I could not find *why* optimization is necessary for that test case,
> so don't know if disabling inlining is the correct fix :(
Like Michael said, we have to assume the obvious, which is that they
wanted to test unwinding of optimized code.
> 2008-02-12 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> *gdb.base/mips_pro.exp: compile with gcc -fno-inline,
> lest gcc-4.3.1 optimizes the whole thing away.
With that in mind, your patch makes sense. We want optimized code, but
not that much optimization :).
--
Joel
next prev parent reply other threads:[~2008-09-04 23:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 0:27 Paul Pluzhnikov
2008-08-22 0:47 ` Michael Snyder
2008-08-29 23:34 ` Paul Pluzhnikov
2008-09-04 23:59 ` Joel Brobecker [this message]
2008-09-05 5:16 ` Paul Pluzhnikov
2008-09-05 13:59 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080904235828.GA29631@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox