Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Paul Pluzhnikov" <ppluzhnikov@google.com>
To: "Joel Brobecker" <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix for failing gdb.base/mips_pro.exp under gcc-4.3.1
Date: Fri, 05 Sep 2008 05:16:00 -0000	[thread overview]
Message-ID: <8ac60eac0809042215j4c2c306dva025addd7bc418d6@mail.gmail.com> (raw)
In-Reply-To: <20080904235828.GA29631@adacore.com>

On Thu, Sep 4, 2008 at 4:58 PM, Joel Brobecker <brobecker@adacore.com> wrote:
> (sorry about the delay - it looks like everyone was very very busy
> this summer)
>
>> I could not find *why* optimization is necessary for that test case,
>> so don't know if disabling inlining is the correct fix :(
>
> Like Michael said, we have to assume the obvious, which is that they
> wanted to test unwinding of optimized code.
>
>> 2008-02-12  Paul Pluzhnikov  <ppluzhnikov@google.com>

Hmm, that should have been 2008-08-22 ...

>>
>>       *gdb.base/mips_pro.exp: compile with gcc -fno-inline,
>>       lest gcc-4.3.1 optimizes the whole thing away.
>
> With that in mind, your patch makes sense. We want optimized code, but
> not that much optimization :).

So ok to commit?

Thanks,
-- 
Paul Pluzhnikov


  reply	other threads:[~2008-09-05  5:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-22  0:27 Paul Pluzhnikov
2008-08-22  0:47 ` Michael Snyder
2008-08-29 23:34 ` Paul Pluzhnikov
2008-09-04 23:59 ` Joel Brobecker
2008-09-05  5:16   ` Paul Pluzhnikov [this message]
2008-09-05 13:59     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ac60eac0809042215j4c2c306dva025addd7bc418d6@mail.gmail.com \
    --to=ppluzhnikov@google.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox