From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-58153-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11766 invoked by alias); 22 Aug 2008 00:27:48 -0000
Received: (qmail 11756 invoked by uid 22791); 22 Aug 2008 00:27:47 -0000
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 22 Aug 2008 00:27:15 +0000
Received: from zps18.corp.google.com (zps18.corp.google.com [172.25.146.18]) 	by smtp-out.google.com with ESMTP id m7M0Qt9d020515 	for <gdb-patches@sourceware.org>; Fri, 22 Aug 2008 01:26:56 +0100
Received: from localhost (elbrus.corp.google.com [172.18.116.17]) 	by zps18.corp.google.com with ESMTP id m7M0QrrA023767; 	Thu, 21 Aug 2008 17:26:54 -0700
Received: by localhost (Postfix, from userid 74925) 	id A73DF3A67DF; Thu, 21 Aug 2008 17:26:53 -0700 (PDT)
To: gdb-patches@sourceware.org
Subject: [patch] Fix for failing gdb.base/mips_pro.exp under gcc-4.3.1
Message-Id: <20080822002653.A73DF3A67DF@localhost>
Date: Fri, 22 Aug 2008 00:27:00 -0000
From: ppluzhnikov@google.com (Paul Pluzhnikov)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-08/txt/msg00576.txt.bz2

Greetings,

Gcc-4.3.1 optimizes the whole thing away:

(gdb) disas main
Dump of assembler code for function main:
0x0000000000400340 <main+0>:    mov    $0x16,%eax
0x0000000000400345 <main+5>:    retq   
End of assembler dump.

Attached patch disables inlining.

The -O2 flag was added here:

  Sun Mar 17 13:35:31 1996  Fred Fish  <fnf@cygnus.com>

        * gdb.base/mips_pro.exp: Create mips_pro.ci to get gcc_compiled
        defined, and use it to compile the test case with -O2.  The
        native compilation still uses no optimization.

I could not find *why* optimization is necessary for that test case,
so don't know if disabling inlining is the correct fix :(

--
Paul Pluzhnikov

2008-02-12  Paul Pluzhnikov  <ppluzhnikov@google.com>

	*gdb.base/mips_pro.exp: compile with gcc -fno-inline,
	lest gcc-4.3.1 optimizes the whole thing away.
	

Index: gdb.base/mips_pro.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/mips_pro.exp,v
retrieving revision 1.10
diff -u -p -u -r1.10 mips_pro.exp
--- gdb.base/mips_pro.exp	6 Aug 2008 12:52:07 -0000	1.10
+++ gdb.base/mips_pro.exp	22 Aug 2008 00:20:15 -0000
@@ -35,7 +35,8 @@ if [get_compiler_info ${binfile}] {
 # This test must be compiled with -O2 if using gcc.
 
 if { [test_compiler_info gcc-*-*] } then {
-    if  { [gdb_compile "${srcdir}/$subdir/${srcfile}" "${binfile}" executable {debug additional_flags=-O2}] != "" } {
+    if  { [gdb_compile "${srcdir}/$subdir/${srcfile}" "${binfile}" \
+	    executable {debug additional_flags=-O2 additional_flags=-fno-inline}] != "" } {
      untested mips_pro.exp
      return -1
     }