Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: luisgpm@linux.vnet.ibm.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH-ppc 2/5] Add VSX support for core-files
Date: Thu, 21 Aug 2008 19:53:00 -0000	[thread overview]
Message-ID: <200808211952.m7LJql2I015916@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <1218208649.24254.12.camel@gargoyle> from "Luis Machado" at Aug 08, 2008 12:17:29 PM

Luis Machado wrote:

> >    { ".reg", 268 },
> >    { ".reg2", 264 },
> >    { ".reg-ppc-vmx", 544 },
> > +  { ".reg-ppc-vsx", 256 },
> >    { NULL, 0}

This patch seems to cause a testsuite regression: generate-core-file
will now *always* add a VSX section, even if the current target does
not actually support VSX registers.  Therefore, on reading the core
file back in, the output of "info all-registers" is different than
before.

I think you should install different versions of ppc_linux_regset_sections
depending on the target properties (which you can inspect via
tdesc_find_feature (info.target_desc, ...) in ppc_linux_init_abi.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2008-08-21 19:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-25 20:16 Luis Machado
2008-08-08 15:18 ` Luis Machado
2008-08-21 19:53   ` Ulrich Weigand [this message]
2008-08-21 21:10     ` Luis Machado
2008-08-21 21:14       ` Ulrich Weigand
2008-08-22 22:32         ` Luis Machado
2008-08-25 18:27           ` Ulrich Weigand
2008-08-26 15:32             ` Luis Machado
2008-08-14 19:52 ` Ulrich Weigand
2008-08-15  5:14   ` Luis Machado
2008-08-15 15:27   ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808211952.m7LJql2I015916@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luisgpm@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox