Re: [PATCH-ppc 2/5] Add VSX support for core-files

[Luis Machado <luisgpm@linux.vnet.ibm.com>]

On Thu, 2008-08-14 at 21:51 +0200, Ulrich Weigand wrote:
> Luis Machado wrote:
> 
> > 2008-07-25  Luis Machado  <luisgpm@br.ibm.com>
> > 
> > 	* ppc-linux-tdep.c (ppc_linux_regset_sections): Add new ".reg-ppc-vsx" field.
> > 	(ppc32_linux_vsxregset): New 32-bit VSX-enabled regset.
> > 	(ppc_linux_regset_from_core_section): Handle VSX core section.
> > 	(ppc_linux_core_read_description): Support VSX-enabled core files.
> > 
> > 	* corelow.c (get_core_register_section): Support VSX-enabled 
> > 	core files.
> 
> This is OK.
> 
> > Index: gdb/corelow.c
> > ===================================================================
> > --- gdb.orig/corelow.c	2008-07-23 09:28:09.000000000 -0700
> > +++ gdb/corelow.c	2008-07-23 09:31:44.000000000 -0700
> > @@ -499,6 +499,8 @@
> >  			     ".reg-xfp", 3, "extended floating-point", 0);
> >    get_core_register_section (regcache,
> >    			     ".reg-ppc-vmx", 3, "ppc Altivec", 0);
> > +  get_core_register_section (regcache,
> > +			     ".reg-ppc-vsx", 4, "POWER7 VSX", 0);
> 
> It would be nice if we could convert this to a loop using the
> gdbarch_core_regset_sections list at some point ...
> 
> Bye,
> Ulrich

Checked in.

Luis