Re: [PATCH-ppc 2/5] Add VSX support for core-files

[Luis Machado <luisgpm@linux.vnet.ibm.com>]

On Thu, 2008-08-21 at 21:52 +0200, Ulrich Weigand wrote:
> Luis Machado wrote:
> 
> > >    { ".reg", 268 },
> > >    { ".reg2", 264 },
> > >    { ".reg-ppc-vmx", 544 },
> > > +  { ".reg-ppc-vsx", 256 },
> > >    { NULL, 0}
> 
> This patch seems to cause a testsuite regression: generate-core-file
> will now *always* add a VSX section, even if the current target does
> not actually support VSX registers.  Therefore, on reading the core
> file back in, the output of "info all-registers" is different than
> before.
> 
> I think you should install different versions of ppc_linux_regset_sections
> depending on the target properties (which you can inspect via
> tdesc_find_feature (info.target_desc, ...) in ppc_linux_init_abi.
> 
> Bye,
> Ulrich

Yes. I think this is currently expected given the current code. 

For example, the core file generated with "gcore" on a 440 system will
dump VMX registers as well, and that target doesn't even have VMX
registers there. 

A new check should suffice for that. We will need three kinds of sets
then: VSX-able, VMX-able and neither VSX or VMX. How does it sound?

Regards,
Luis