From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2999 invoked by alias); 21 Aug 2008 21:10:18 -0000 Received: (qmail 2988 invoked by uid 22791); 21 Aug 2008 21:10:17 -0000 X-Spam-Check-By: sourceware.org Received: from igw1.br.ibm.com (HELO igw1.br.ibm.com) (32.104.18.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 21 Aug 2008 21:09:33 +0000 Received: from mailhub1.br.ibm.com (mailhub1 [9.18.232.109]) by igw1.br.ibm.com (Postfix) with ESMTP id 73AB732C162 for ; Thu, 21 Aug 2008 17:40:06 -0300 (BRT) Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m7LKp4XM2224600 for ; Thu, 21 Aug 2008 18:09:33 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m7LKTEZ3011546 for ; Thu, 21 Aug 2008 17:29:14 -0300 Received: from [9.8.6.166] ([9.8.6.166]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m7LKTDqN010929 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 21 Aug 2008 17:29:14 -0300 Subject: Re: [PATCH-ppc 2/5] Add VSX support for core-files From: Luis Machado Reply-To: luisgpm@linux.vnet.ibm.com To: Ulrich Weigand Cc: gdb-patches@sourceware.org In-Reply-To: <200808211952.m7LJql2I015916@d12av02.megacenter.de.ibm.com> References: <200808211952.m7LJql2I015916@d12av02.megacenter.de.ibm.com> Content-Type: text/plain Date: Thu, 21 Aug 2008 21:10:00 -0000 Message-Id: <1219350529.28934.6.camel@gargoyle> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00567.txt.bz2 On Thu, 2008-08-21 at 21:52 +0200, Ulrich Weigand wrote: > Luis Machado wrote: > > > > { ".reg", 268 }, > > > { ".reg2", 264 }, > > > { ".reg-ppc-vmx", 544 }, > > > + { ".reg-ppc-vsx", 256 }, > > > { NULL, 0} > > This patch seems to cause a testsuite regression: generate-core-file > will now *always* add a VSX section, even if the current target does > not actually support VSX registers. Therefore, on reading the core > file back in, the output of "info all-registers" is different than > before. > > I think you should install different versions of ppc_linux_regset_sections > depending on the target properties (which you can inspect via > tdesc_find_feature (info.target_desc, ...) in ppc_linux_init_abi. > > Bye, > Ulrich Yes. I think this is currently expected given the current code. For example, the core file generated with "gcore" on a 440 system will dump VMX registers as well, and that target doesn't even have VMX registers there. A new check should suffice for that. We will need three kinds of sets then: VSX-able, VMX-able and neither VSX or VMX. How does it sound? Regards, Luis