From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19234 invoked by alias); 21 Aug 2008 19:53:34 -0000 Received: (qmail 19225 invoked by uid 22791); 21 Aug 2008 19:53:33 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate1.de.ibm.com (HELO mtagate1.de.ibm.com) (195.212.17.161) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 21 Aug 2008 19:52:51 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.1/8.13.1) with ESMTP id m7LJqlhH004197 for ; Thu, 21 Aug 2008 19:52:47 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m7LJqluQ3604528 for ; Thu, 21 Aug 2008 21:52:47 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m7LJqlCE015919 for ; Thu, 21 Aug 2008 21:52:47 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m7LJql2I015916; Thu, 21 Aug 2008 21:52:47 +0200 Message-Id: <200808211952.m7LJql2I015916@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 21 Aug 2008 21:52:47 +0200 Subject: Re: [PATCH-ppc 2/5] Add VSX support for core-files To: luisgpm@linux.vnet.ibm.com Date: Thu, 21 Aug 2008 19:53:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <1218208649.24254.12.camel@gargoyle> from "Luis Machado" at Aug 08, 2008 12:17:29 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00561.txt.bz2 Luis Machado wrote: > > { ".reg", 268 }, > > { ".reg2", 264 }, > > { ".reg-ppc-vmx", 544 }, > > + { ".reg-ppc-vsx", 256 }, > > { NULL, 0} This patch seems to cause a testsuite regression: generate-core-file will now *always* add a VSX section, even if the current target does not actually support VSX registers. Therefore, on reading the core file back in, the output of "info all-registers" is different than before. I think you should install different versions of ppc_linux_regset_sections depending on the target properties (which you can inspect via tdesc_find_feature (info.target_desc, ...) in ppc_linux_init_abi. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com