* [7/7] Adjust the SPU linux native target
@ 2008-08-08 1:40 Pedro Alves
2008-08-08 18:17 ` Ulrich Weigand
0 siblings, 1 reply; 2+ messages in thread
From: Pedro Alves @ 2008-08-08 1:40 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 391 bytes --]
Now that the fork_inferior takes care of adding the main thread for
the target_create_inferior case, and inf_ptrace_attach adds it
for the target_attach case, the SPU target, which extends the ptrace target
should no longer add it.
Unfortunatelly, I have no means to test this. Ulrich, does this look OK?
You only need patches 1, 2 and this one for the SPU changes.
OK?
--
Pedro Alves
[-- Attachment #2: 007-spu.diff --]
[-- Type: text/x-diff, Size: 1045 bytes --]
2008-08-08 Pedro Alves <pedro@codesourcery.com>
* spu-linux-nat.c (spu_child_post_startup_inferior)
(spu_child_post_attach): Don't add the main thread here.
---
gdb/spu-linux-nat.c | 4 ----
1 file changed, 4 deletions(-)
Index: src/gdb/spu-linux-nat.c
===================================================================
--- src.orig/gdb/spu-linux-nat.c 2008-07-29 11:29:27.000000000 +0100
+++ src/gdb/spu-linux-nat.c 2008-07-29 11:31:12.000000000 +0100
@@ -376,8 +376,6 @@ spu_child_post_startup_inferior (ptid_t
ptrace (PT_SYSCALL, tid, (PTRACE_TYPE_ARG3) 0, 0);
waitpid (tid, NULL, __WALL | __WNOTHREAD);
}
-
- add_thread_silent (ptid);
}
/* Override the post_attach routine to try load the SPE executable
@@ -397,8 +395,6 @@ spu_child_post_attach (int pid)
waitpid (pid, NULL, __WALL | __WNOTHREAD);
}
- add_thread_silent (inferior_ptid);
-
/* If the user has not provided an executable file, try to extract
the image from inside the target process. */
if (!get_exec_file (0))
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [7/7] Adjust the SPU linux native target
2008-08-08 1:40 [7/7] Adjust the SPU linux native target Pedro Alves
@ 2008-08-08 18:17 ` Ulrich Weigand
0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Weigand @ 2008-08-08 18:17 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches
Pedro Alves wrote:
> Unfortunatelly, I have no means to test this. Ulrich, does this look OK?
>
> You only need patches 1, 2 and this one for the SPU changes.
These three patches pass testing on spu-elf with no regressions.
> 2008-08-08 Pedro Alves <pedro@codesourcery.com>
>
> * spu-linux-nat.c (spu_child_post_startup_inferior)
> (spu_child_post_attach): Don't add the main thread here.
Assuming the rest of the series goes in, this patch is OK.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-08 18:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-08-08 1:40 [7/7] Adjust the SPU linux native target Pedro Alves
2008-08-08 18:17 ` Ulrich Weigand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox