Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: [7/7] Adjust the SPU linux native target
Date: Fri, 08 Aug 2008 01:40:00 -0000	[thread overview]
Message-ID: <200808080240.50260.pedro@codesourcery.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

Now that the fork_inferior takes care of adding the main thread for
the target_create_inferior case, and inf_ptrace_attach adds it
for the target_attach case, the SPU target, which extends the ptrace target
should no longer add it.

Unfortunatelly, I have no means to test this.  Ulrich, does this look OK?

You only need patches 1, 2 and this one for the SPU changes.

OK?

-- 
Pedro Alves

[-- Attachment #2: 007-spu.diff --]
[-- Type: text/x-diff, Size: 1045 bytes --]

2008-08-08  Pedro Alves  <pedro@codesourcery.com>

	* spu-linux-nat.c (spu_child_post_startup_inferior)
	(spu_child_post_attach): Don't add the main thread here.

---
 gdb/spu-linux-nat.c |    4 ----
 1 file changed, 4 deletions(-)

Index: src/gdb/spu-linux-nat.c
===================================================================
--- src.orig/gdb/spu-linux-nat.c	2008-07-29 11:29:27.000000000 +0100
+++ src/gdb/spu-linux-nat.c	2008-07-29 11:31:12.000000000 +0100
@@ -376,8 +376,6 @@ spu_child_post_startup_inferior (ptid_t 
       ptrace (PT_SYSCALL, tid, (PTRACE_TYPE_ARG3) 0, 0);
       waitpid (tid, NULL, __WALL | __WNOTHREAD);
     }
-
-  add_thread_silent (ptid);
 }
 
 /* Override the post_attach routine to try load the SPE executable
@@ -397,8 +395,6 @@ spu_child_post_attach (int pid)
       waitpid (pid, NULL, __WALL | __WNOTHREAD);
     }
 
-  add_thread_silent (inferior_ptid);
-
   /* If the user has not provided an executable file, try to extract
      the image from inside the target process.  */
   if (!get_exec_file (0))

             reply	other threads:[~2008-08-08  1:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08  1:40 Pedro Alves [this message]
2008-08-08 18:17 ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808080240.50260.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox