Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFA] Fix for failing gdb.base/foll-fork.exp on Linux with VDSO
@ 2008-07-17 20:27 Paul Pluzhnikov
  2008-07-17 20:53 ` Daniel Jacobowitz
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Pluzhnikov @ 2008-07-17 20:27 UTC (permalink / raw)
  To: gdb-patches

Greetings,

gdb.base/foll-fork.exp is failing for me on Linux with VDSO:

(gdb) r

Catchpoint 1 (forked process 24244), 0xffffe410 in __kernel_vsyscall ()
(gdb) bt
#0  0xffffe410 in __kernel_vsyscall ()
#1  0x4dc3a456 in fork () from /lib/tls/i686/cmov/libc.so.6
#2  0x080483df in main () at ../../../src/gdb/testsuite/gdb.base/foll-fork.c:23
(gdb) 


Attached patch fixes that.

Ok to commit?

--
Paul Pluzhnikov

2008-07-17  Paul Pluzhnikov  <ppluzhnikov@google.com>

	* gdb.base/foll-fork.exp: Fix for Linux/VDSO failure.


Index: testsuite/gdb.base/foll-fork.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/foll-fork.exp,v
retrieving revision 1.9
diff -u -p -u -r1.9 foll-fork.exp
--- testsuite/gdb.base/foll-fork.exp	15 Apr 2008 14:33:54 -0000	1.9
+++ testsuite/gdb.base/foll-fork.exp	17 Jul 2008 20:25:16 -0000
@@ -170,7 +170,7 @@ proc catch_fork_child_follow {} {
 
    send_gdb "continue\n"
    gdb_expect {
-      -re "Catchpoint.*(forked process.*),.*in .*fork.*$gdb_prompt $"\
+      -re "Catchpoint.*(forked process.*),.*in .*(fork|__kernel_vsyscall).*$gdb_prompt $"\
                       {pass "explicit child follow, catch fork"}
       -re "$gdb_prompt $" {fail "explicit child follow, catch fork"}
       timeout         {fail "(timeout) explicit child follow, catch fork"}
@@ -243,7 +243,7 @@ proc tcatch_fork_parent_follow {} {
 
    send_gdb "continue\n"
    gdb_expect {
-      -re ".*in .*fork.*$gdb_prompt $"\
+      -re ".*in .*(fork|__kernel_vsyscall).*$gdb_prompt $"\
                       {pass "explicit parent follow, tcatch fork"}
       -re "$gdb_prompt $" {fail "explicit parent follow, tcatch fork"}
       timeout         {fail "(timeout) explicit parent follow, tcatch fork"}


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [RFA] Fix for failing gdb.base/foll-fork.exp on Linux with VDSO
  2008-07-17 20:27 [RFA] Fix for failing gdb.base/foll-fork.exp on Linux with VDSO Paul Pluzhnikov
@ 2008-07-17 20:53 ` Daniel Jacobowitz
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Jacobowitz @ 2008-07-17 20:53 UTC (permalink / raw)
  To: Paul Pluzhnikov; +Cc: gdb-patches

On Thu, Jul 17, 2008 at 01:26:34PM -0700, Paul Pluzhnikov wrote:
> 2008-07-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
> 
> 	* gdb.base/foll-fork.exp: Fix for Linux/VDSO failure.

OK.

-- 
Daniel Jacobowitz
CodeSourcery


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-07-17 20:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-17 20:27 [RFA] Fix for failing gdb.base/foll-fork.exp on Linux with VDSO Paul Pluzhnikov
2008-07-17 20:53 ` Daniel Jacobowitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox