From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5748 invoked by alias); 17 Jul 2008 20:27:02 -0000 Received: (qmail 5737 invoked by uid 22791); 17 Jul 2008 20:27:01 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 17 Jul 2008 20:26:44 +0000 Received: from wpaz29.hot.corp.google.com (wpaz29.hot.corp.google.com [172.24.198.93]) by smtp-out3.google.com with ESMTP id m6HKQdV5025887 for ; Thu, 17 Jul 2008 21:26:39 +0100 Received: from localhost (elbrus.corp.google.com [172.18.116.17]) by wpaz29.hot.corp.google.com with ESMTP id m6HKQYIE007022; Thu, 17 Jul 2008 13:26:35 -0700 Received: by localhost (Postfix, from userid 74925) id C4AEA3A67B6; Thu, 17 Jul 2008 13:26:34 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [RFA] Fix for failing gdb.base/foll-fork.exp on Linux with VDSO Message-Id: <20080717202634.C4AEA3A67B6@localhost> Date: Thu, 17 Jul 2008 20:27:00 -0000 From: ppluzhnikov@google.com (Paul Pluzhnikov) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00344.txt.bz2 Greetings, gdb.base/foll-fork.exp is failing for me on Linux with VDSO: (gdb) r Catchpoint 1 (forked process 24244), 0xffffe410 in __kernel_vsyscall () (gdb) bt #0 0xffffe410 in __kernel_vsyscall () #1 0x4dc3a456 in fork () from /lib/tls/i686/cmov/libc.so.6 #2 0x080483df in main () at ../../../src/gdb/testsuite/gdb.base/foll-fork.c:23 (gdb) Attached patch fixes that. Ok to commit? -- Paul Pluzhnikov 2008-07-17 Paul Pluzhnikov * gdb.base/foll-fork.exp: Fix for Linux/VDSO failure. Index: testsuite/gdb.base/foll-fork.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/foll-fork.exp,v retrieving revision 1.9 diff -u -p -u -r1.9 foll-fork.exp --- testsuite/gdb.base/foll-fork.exp 15 Apr 2008 14:33:54 -0000 1.9 +++ testsuite/gdb.base/foll-fork.exp 17 Jul 2008 20:25:16 -0000 @@ -170,7 +170,7 @@ proc catch_fork_child_follow {} { send_gdb "continue\n" gdb_expect { - -re "Catchpoint.*(forked process.*),.*in .*fork.*$gdb_prompt $"\ + -re "Catchpoint.*(forked process.*),.*in .*(fork|__kernel_vsyscall).*$gdb_prompt $"\ {pass "explicit child follow, catch fork"} -re "$gdb_prompt $" {fail "explicit child follow, catch fork"} timeout {fail "(timeout) explicit child follow, catch fork"} @@ -243,7 +243,7 @@ proc tcatch_fork_parent_follow {} { send_gdb "continue\n" gdb_expect { - -re ".*in .*fork.*$gdb_prompt $"\ + -re ".*in .*(fork|__kernel_vsyscall).*$gdb_prompt $"\ {pass "explicit parent follow, tcatch fork"} -re "$gdb_prompt $" {fail "explicit parent follow, tcatch fork"} timeout {fail "(timeout) explicit parent follow, tcatch fork"}