Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: ppluzhnikov@google.com (Paul Pluzhnikov)
To: gdb-patches@sourceware.org
Subject: [RFA] Fix for failing gdb.base/foll-fork.exp on Linux with VDSO
Date: Thu, 17 Jul 2008 20:27:00 -0000	[thread overview]
Message-ID: <20080717202634.C4AEA3A67B6@localhost> (raw)

Greetings,

gdb.base/foll-fork.exp is failing for me on Linux with VDSO:

(gdb) r

Catchpoint 1 (forked process 24244), 0xffffe410 in __kernel_vsyscall ()
(gdb) bt
#0  0xffffe410 in __kernel_vsyscall ()
#1  0x4dc3a456 in fork () from /lib/tls/i686/cmov/libc.so.6
#2  0x080483df in main () at ../../../src/gdb/testsuite/gdb.base/foll-fork.c:23
(gdb) 


Attached patch fixes that.

Ok to commit?

--
Paul Pluzhnikov

2008-07-17  Paul Pluzhnikov  <ppluzhnikov@google.com>

	* gdb.base/foll-fork.exp: Fix for Linux/VDSO failure.


Index: testsuite/gdb.base/foll-fork.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/foll-fork.exp,v
retrieving revision 1.9
diff -u -p -u -r1.9 foll-fork.exp
--- testsuite/gdb.base/foll-fork.exp	15 Apr 2008 14:33:54 -0000	1.9
+++ testsuite/gdb.base/foll-fork.exp	17 Jul 2008 20:25:16 -0000
@@ -170,7 +170,7 @@ proc catch_fork_child_follow {} {
 
    send_gdb "continue\n"
    gdb_expect {
-      -re "Catchpoint.*(forked process.*),.*in .*fork.*$gdb_prompt $"\
+      -re "Catchpoint.*(forked process.*),.*in .*(fork|__kernel_vsyscall).*$gdb_prompt $"\
                       {pass "explicit child follow, catch fork"}
       -re "$gdb_prompt $" {fail "explicit child follow, catch fork"}
       timeout         {fail "(timeout) explicit child follow, catch fork"}
@@ -243,7 +243,7 @@ proc tcatch_fork_parent_follow {} {
 
    send_gdb "continue\n"
    gdb_expect {
-      -re ".*in .*fork.*$gdb_prompt $"\
+      -re ".*in .*(fork|__kernel_vsyscall).*$gdb_prompt $"\
                       {pass "explicit parent follow, tcatch fork"}
       -re "$gdb_prompt $" {fail "explicit parent follow, tcatch fork"}
       timeout         {fail "(timeout) explicit parent follow, tcatch fork"}


             reply	other threads:[~2008-07-17 20:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-17 20:27 Paul Pluzhnikov [this message]
2008-07-17 20:53 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080717202634.C4AEA3A67B6@localhost \
    --to=ppluzhnikov@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox