From: Daniel Jacobowitz <drow@false.org>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Patch for PR gdb/2477
Date: Mon, 14 Jul 2008 18:21:00 -0000 [thread overview]
Message-ID: <20080714182042.GA12321@caradoc.them.org> (raw)
In-Reply-To: <8ac60eac0807141111r58b047a3j7fd4a39080b1be19@mail.gmail.com>
On Mon, Jul 14, 2008 at 11:11:59AM -0700, Paul Pluzhnikov wrote:
> There is something special about zero -- it very frequently occurs
> in correct C++ programs :)
Well, true :-)
> I've also added a "non-zero but invalid" pointer test at ~0UL.
> Is there a "canonical" invalid address I should be testing instead?
Nope, this is fine.
The patch is OK - if you'll update the dependencies for cp-abi.o in
Makefile.in also.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-07-14 18:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-14 17:32 Paul Pluzhnikov
2008-07-14 17:43 ` Daniel Jacobowitz
2008-07-14 18:12 ` Paul Pluzhnikov
2008-07-14 18:21 ` Daniel Jacobowitz [this message]
2008-07-14 18:30 ` Paul Pluzhnikov
2008-07-15 18:52 ` Ulrich Weigand
2008-07-15 19:03 ` Daniel Jacobowitz
2008-07-15 19:16 ` Paul Pluzhnikov
2008-07-15 20:04 ` Ulrich Weigand
2008-07-15 19:04 ` Paul Pluzhnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080714182042.GA12321@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox