From: "Paul Pluzhnikov" <ppluzhnikov@google.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>,
"Paul Pluzhnikov" <ppluzhnikov@google.com>,
gdb-patches@sourceware.org
Subject: Re: [RFA] Patch for PR gdb/2477
Date: Tue, 15 Jul 2008 19:16:00 -0000 [thread overview]
Message-ID: <8ac60eac0807151215g5366f2d3l8e7302b057a3d160@mail.gmail.com> (raw)
In-Reply-To: <20080715190332.GD32644@caradoc.them.org>
On Tue, Jul 15, 2008 at 12:03 PM, Daniel Jacobowitz <drow@false.org> wrote:
> Ignoring the number entirely should preserve the intention of the test
> - we're interested in the "A *" and in there being no error message.
> "${hex}f"?
I didn't know about ${hex}.
Committed as below.
Thanks,
--
Paul Pluzhnikov
2008-07-15 Paul Pluzhnikov <ppluzhnikov@google.com>
* gdb.cp/class2.exp: fix for failure on spu-elf
Index: testsuite/gdb.cp/class2.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/class2.exp,v
retrieving revision 1.7
diff -u -p -u -r1.7 class2.exp
--- testsuite/gdb.cp/class2.exp 14 Jul 2008 18:28:57 -0000 1.7
+++ testsuite/gdb.cp/class2.exp 15 Jul 2008 19:08:07 -0000
@@ -121,6 +121,6 @@ gdb_test "p e" "= \{<No data fields>\}"
# Printing NULL pointers with "set print object on"
gdb_test "set print object on" ""
-gdb_test "p acp" "= \\(C \\*\\) 0x\[a-f0-9\]+"
+gdb_test "p acp" "= \\(C \\*\\) ${hex}"
gdb_test "p acp->c1" "\\(A \\*\\) 0x0"
-gdb_test "p acp->c2" "\\(A \\*\\) 0xf+"
+gdb_test "p acp->c2" "\\(A \\*\\) ${hex}f"
next prev parent reply other threads:[~2008-07-15 19:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-14 17:32 Paul Pluzhnikov
2008-07-14 17:43 ` Daniel Jacobowitz
2008-07-14 18:12 ` Paul Pluzhnikov
2008-07-14 18:21 ` Daniel Jacobowitz
2008-07-14 18:30 ` Paul Pluzhnikov
2008-07-15 18:52 ` Ulrich Weigand
2008-07-15 19:03 ` Daniel Jacobowitz
2008-07-15 19:16 ` Paul Pluzhnikov [this message]
2008-07-15 20:04 ` Ulrich Weigand
2008-07-15 19:04 ` Paul Pluzhnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ac60eac0807151215g5366f2d3l8e7302b057a3d160@mail.gmail.com \
--to=ppluzhnikov@google.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox