From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24676 invoked by alias); 15 Jul 2008 19:16:22 -0000 Received: (qmail 24668 invoked by uid 22791); 15 Jul 2008 19:16:21 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 15 Jul 2008 19:16:04 +0000 Received: from wpaz37.hot.corp.google.com (wpaz37.hot.corp.google.com [172.24.198.101]) by smtp-out.google.com with ESMTP id m6FJFv7j012280 for ; Tue, 15 Jul 2008 20:15:58 +0100 Received: from el-out-1112.google.com (elez25.prod.google.com [10.126.177.25]) by wpaz37.hot.corp.google.com with ESMTP id m6FJFmhP004544 for ; Tue, 15 Jul 2008 12:15:57 -0700 Received: by el-out-1112.google.com with SMTP id z25so935774ele.15 for ; Tue, 15 Jul 2008 12:15:57 -0700 (PDT) Received: by 10.150.49.1 with SMTP id w1mr820610ybw.24.1216149357246; Tue, 15 Jul 2008 12:15:57 -0700 (PDT) Received: by 10.151.109.14 with HTTP; Tue, 15 Jul 2008 12:15:56 -0700 (PDT) Message-ID: <8ac60eac0807151215g5366f2d3l8e7302b057a3d160@mail.gmail.com> Date: Tue, 15 Jul 2008 19:16:00 -0000 From: "Paul Pluzhnikov" To: "Ulrich Weigand" , "Paul Pluzhnikov" , gdb-patches@sourceware.org Subject: Re: [RFA] Patch for PR gdb/2477 In-Reply-To: <20080715190332.GD32644@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <8ac60eac0807141111r58b047a3j7fd4a39080b1be19@mail.gmail.com> <200807151852.m6FIqECB022335@d12av02.megacenter.de.ibm.com> <20080715190332.GD32644@caradoc.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00323.txt.bz2 On Tue, Jul 15, 2008 at 12:03 PM, Daniel Jacobowitz wrote: > Ignoring the number entirely should preserve the intention of the test > - we're interested in the "A *" and in there being no error message. > "${hex}f"? I didn't know about ${hex}. Committed as below. Thanks, -- Paul Pluzhnikov 2008-07-15 Paul Pluzhnikov * gdb.cp/class2.exp: fix for failure on spu-elf Index: testsuite/gdb.cp/class2.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/class2.exp,v retrieving revision 1.7 diff -u -p -u -r1.7 class2.exp --- testsuite/gdb.cp/class2.exp 14 Jul 2008 18:28:57 -0000 1.7 +++ testsuite/gdb.cp/class2.exp 15 Jul 2008 19:08:07 -0000 @@ -121,6 +121,6 @@ gdb_test "p e" "= \{\}" # Printing NULL pointers with "set print object on" gdb_test "set print object on" "" -gdb_test "p acp" "= \\(C \\*\\) 0x\[a-f0-9\]+" +gdb_test "p acp" "= \\(C \\*\\) ${hex}" gdb_test "p acp->c1" "\\(A \\*\\) 0x0" -gdb_test "p acp->c2" "\\(A \\*\\) 0xf+" +gdb_test "p acp->c2" "\\(A \\*\\) ${hex}f"