Re: [RFA] Patch for PR gdb/2477

Paul Pluzhnikov
2008-07-14T18:12:27Z

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

On Mon, Jul 14, 2008 at 10:42 AM, Daniel Jacobowitz <drow@false.org> wrote:

> There's nothing special about zero. It's just an unreadable memory
> address; the same problem will reappear with any other invalid
> pointer.

There is something special about zero -- it very frequently occurs
in correct C++ programs :)

> So if we use TRY_CATCH and RETURN_MASK_ERROR around the call to
> current_cp_abi.rtti_type, we can return NULL in the error case.

Done.

I've also added a "non-zero but invalid" pointer test at ~0UL.
Is there a "canonical" invalid address I should be testing instead?

Thanks,
--
Paul Pluzhnikov

ChangeLog
2008-07-14 Paul Pluzhnikov <ppluzhnikov@google.com>

PR gdb/2477
* cp-abi.c (value_virtual_fn_field): Handle invalid pointers.

testsuite/ChangeLog
2008-07-14 Paul Pluzhnikov <ppluzhnikov@google.com>

* gdb.cp/class2.exp, gdb.cp/class2.cc: Test for PR2477.

[-- Attachment #2: gdb-patch-2477-20080714-2.txt --]
[-- Type: text/plain, Size: 2645 bytes --]

Index: gdb/cp-abi.c
===================================================================
RCS file: /cvs/src/src/gdb/cp-abi.c,v
retrieving revision 1.21
diff -u -p -u -r1.21 cp-abi.c
--- gdb/cp-abi.c 1 Jan 2008 22:53:09 -0000 1.21
+++ gdb/cp-abi.c 14 Jul 2008 18:01:19 -0000
@@ -22,6 +22,7 @@
#include "value.h"
#include "cp-abi.h"
#include "command.h"
+#include "exceptions.h"
#include "gdbcmd.h"
#include "ui-out.h"

@@ -89,9 +90,17 @@ value_virtual_fn_field (struct value **a
struct type *
value_rtti_type (struct value *v, int *full, int *top, int *using_enc)
{
+ struct type *ret = NULL;
+ struct gdb_exception e;
if ((current_cp_abi.rtti_type) == NULL)
return NULL;
- return (*current_cp_abi.rtti_type) (v, full, top, using_enc);
+ TRY_CATCH (e, RETURN_MASK_ERROR)
+ {
+ ret = (*current_cp_abi.rtti_type) (v, full, top, using_enc);
+ }
+ if (e.reason < 0)
+ return NULL;
+ return ret;
}

void
Index: gdb/testsuite/gdb.cp/class2.cc
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/class2.cc,v
retrieving revision 1.6
diff -u -p -u -r1.6 class2.cc
--- gdb/testsuite/gdb.cp/class2.cc 1 Jan 2008 22:53:19 -0000 1.6
+++ gdb/testsuite/gdb.cp/class2.cc 14 Jul 2008 18:01:19 -0000
@@ -41,6 +41,12 @@ B::~B()
b2 = 902;
}

+struct C : public B
+{
+ A *c1;
+ A *c2;
+};
+
// Stop the compiler from optimizing away data.
void refer (A *)
{
@@ -57,16 +63,19 @@ void refer (empty *)

int main (void)
{
- A alpha, *aap, *abp;
+ A alpha, *aap, *abp, *acp;
B beta, *bbp;
+ C gamma;
empty e;

alpha.a1 = 100;
beta.a1 = 200; beta.b1 = 201; beta.b2 = 202;
+ gamma.c1 = 0; gamma.c2 = (A *) ~0UL;

aap = &alpha; refer (aap);
abp = &beta; refer (abp);
bbp = &beta; refer (bbp);
+ acp = &gamma; refer (acp);
refer (&e);

return 0; // marker return 0
Index: gdb/testsuite/gdb.cp/class2.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/class2.exp,v
retrieving revision 1.6
diff -u -p -u -r1.6 class2.exp
--- gdb/testsuite/gdb.cp/class2.exp 1 Jan 2008 22:53:19 -0000 1.6
+++ gdb/testsuite/gdb.cp/class2.exp 14 Jul 2008 18:01:19 -0000
@@ -117,3 +117,10 @@ gdb_test "print * (B *) abp" \
# Printing the value of an object containing no data fields:

gdb_test "p e" "= \{<No data fields>\}" "print object with no data fields"
+
+# Printing NULL pointers with "set print object on"
+
+gdb_test "set print object on" ""
+gdb_test "p acp" "= \\(C \\*\\) 0x\[a-f0-9\]+"
+gdb_test "p acp->c1" "\\(A \\*\\) 0x0"
+gdb_test "p acp->c2" "\\(A \\*\\) 0xf+"