From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8485 invoked by alias); 14 Jul 2008 18:21:21 -0000 Received: (qmail 8475 invoked by uid 22791); 14 Jul 2008 18:21:20 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 14 Jul 2008 18:20:45 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id BD3969813B; Mon, 14 Jul 2008 18:20:43 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 738539813A; Mon, 14 Jul 2008 18:20:43 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KISfC-0003D3-EA; Mon, 14 Jul 2008 14:20:42 -0400 Date: Mon, 14 Jul 2008 18:21:00 -0000 From: Daniel Jacobowitz To: Paul Pluzhnikov Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Patch for PR gdb/2477 Message-ID: <20080714182042.GA12321@caradoc.them.org> Mail-Followup-To: Paul Pluzhnikov , gdb-patches@sourceware.org References: <20080714173149.A03E63A67B4@localhost> <20080714174245.GA9888@caradoc.them.org> <8ac60eac0807141111r58b047a3j7fd4a39080b1be19@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ac60eac0807141111r58b047a3j7fd4a39080b1be19@mail.gmail.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00291.txt.bz2 On Mon, Jul 14, 2008 at 11:11:59AM -0700, Paul Pluzhnikov wrote: > There is something special about zero -- it very frequently occurs > in correct C++ programs :) Well, true :-) > I've also added a "non-zero but invalid" pointer test at ~0UL. > Is there a "canonical" invalid address I should be testing instead? Nope, this is fine. The patch is OK - if you'll update the dependencies for cp-abi.o in Makefile.in also. -- Daniel Jacobowitz CodeSourcery