[ob] testsuite prepare_for_testing() now drops $options

[ob] testsuite prepare_for_testing() now drops $options

[Jan Kratochvil]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Hi,

http://sourceware.org/ml/gdb-patches/2008-04/msg00039.html

introduced dropping $options for the 3 testcases which use the
PREPARE_FOR_TESTING function now.  Going to commit it as obvious.

It was found as it hid a regression (more just a gcc debuginfo mess, though)
FAIL: gdb.base/break.exp: run until breakpoint set at small function, optimized file
from the recent uncommitted inlining support patch.


Regards,
Jan

[-- Attachment #2: gdb-prepare_for_testing-options.patch --]
[-- Type: text/plain, Size: 660 bytes --]

2008-06-25  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* lib/gdb.exp (prepare_for_testing): Do not drop the OPTIONS argument.

--- ./gdb/testsuite/lib/gdb.exp	4 May 2008 04:04:11 -0000	1.102
+++ ./gdb/testsuite/lib/gdb.exp	25 Jun 2008 15:30:34 -0000
@@ -2732,7 +2732,7 @@ proc clean_restart { executable } {
 # Please refer to build_executable for parameter description.
 proc prepare_for_testing { testname executable {sources ""} {options {debug}}} {
 
-    if {[build_executable $testname $executable $sources] == -1} {
+    if {[build_executable $testname $executable $sources $options] == -1} {
         return -1
     }
     clean_restart $executable

Re: [ob] testsuite prepare_for_testing() now drops $options

[Vladimir Prus]

On Wednesday 25 June 2008 19:37:44 Jan Kratochvil wrote:
> Hi,
> 
> http://sourceware.org/ml/gdb-patches/2008-04/msg00039.html
> 
> introduced dropping $options for the 3 testcases which use the
> PREPARE_FOR_TESTING function now.  Going to commit it as obvious.

It seems obvious indeed -- thanks for fixing!

- Volodya