Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Cc: Vladimir Prus <vladimir@codesourcery.com>
Subject: [ob] testsuite prepare_for_testing() now drops $options
Date: Wed, 25 Jun 2008 15:51:00 -0000	[thread overview]
Message-ID: <20080625153744.GA2248@host0.dyn.jankratochvil.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Hi,

http://sourceware.org/ml/gdb-patches/2008-04/msg00039.html

introduced dropping $options for the 3 testcases which use the
PREPARE_FOR_TESTING function now.  Going to commit it as obvious.

It was found as it hid a regression (more just a gcc debuginfo mess, though)
FAIL: gdb.base/break.exp: run until breakpoint set at small function, optimized file
from the recent uncommitted inlining support patch.


Regards,
Jan

[-- Attachment #2: gdb-prepare_for_testing-options.patch --]
[-- Type: text/plain, Size: 660 bytes --]

2008-06-25  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* lib/gdb.exp (prepare_for_testing): Do not drop the OPTIONS argument.

--- ./gdb/testsuite/lib/gdb.exp	4 May 2008 04:04:11 -0000	1.102
+++ ./gdb/testsuite/lib/gdb.exp	25 Jun 2008 15:30:34 -0000
@@ -2732,7 +2732,7 @@ proc clean_restart { executable } {
 # Please refer to build_executable for parameter description.
 proc prepare_for_testing { testname executable {sources ""} {options {debug}}} {
 
-    if {[build_executable $testname $executable $sources] == -1} {
+    if {[build_executable $testname $executable $sources $options] == -1} {
         return -1
     }
     clean_restart $executable

             reply	other threads:[~2008-06-25 15:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25 15:51 Jan Kratochvil [this message]
2008-06-25 17:49 ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080625153744.GA2248@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox