From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22797 invoked by alias); 25 Jun 2008 15:38:31 -0000 Received: (qmail 22632 invoked by uid 22791); 25 Jun 2008 15:38:30 -0000 X-Spam-Check-By: sourceware.org Received: from host0.dyn.jankratochvil.net (HELO host0.dyn.jankratochvil.net) (89.250.240.59) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 25 Jun 2008 15:37:58 +0000 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.2/8.14.2) with ESMTP id m5PFbjDk002461; Wed, 25 Jun 2008 17:37:45 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.2/8.14.2/Submit) id m5PFbiWJ002460; Wed, 25 Jun 2008 17:37:44 +0200 Date: Wed, 25 Jun 2008 15:51:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Vladimir Prus Subject: [ob] testsuite prepare_for_testing() now drops $options Message-ID: <20080625153744.GA2248@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="vtzGhvizbBRQ85DL" Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00441.txt.bz2 --vtzGhvizbBRQ85DL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 424 Hi, http://sourceware.org/ml/gdb-patches/2008-04/msg00039.html introduced dropping $options for the 3 testcases which use the PREPARE_FOR_TESTING function now. Going to commit it as obvious. It was found as it hid a regression (more just a gcc debuginfo mess, though) FAIL: gdb.base/break.exp: run until breakpoint set at small function, optimized file from the recent uncommitted inlining support patch. Regards, Jan --vtzGhvizbBRQ85DL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="gdb-prepare_for_testing-options.patch" Content-length: 660 2008-06-25 Jan Kratochvil * lib/gdb.exp (prepare_for_testing): Do not drop the OPTIONS argument. --- ./gdb/testsuite/lib/gdb.exp 4 May 2008 04:04:11 -0000 1.102 +++ ./gdb/testsuite/lib/gdb.exp 25 Jun 2008 15:30:34 -0000 @@ -2732,7 +2732,7 @@ proc clean_restart { executable } { # Please refer to build_executable for parameter description. proc prepare_for_testing { testname executable {sources ""} {options {debug}}} { - if {[build_executable $testname $executable $sources] == -1} { + if {[build_executable $testname $executable $sources $options] == -1} { return -1 } clean_restart $executable --vtzGhvizbBRQ85DL--