From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [non-stop] 01/10 Add "executing" property
Date: Mon, 23 Jun 2008 01:13:00 -0000 [thread overview]
Message-ID: <20080623010353.GA23201@caradoc.them.org> (raw)
In-Reply-To: <200806171924.04486.pedro@codesourcery.com>
On Tue, Jun 17, 2008 at 07:24:04PM +0100, Pedro Alves wrote:
> @@ -422,7 +417,10 @@ execute_command (char *p, int from_tty)
>
> /* If the target is running, we allow only a limited set of
> commands. */
> - if (target_can_async_p () && target_executing && !get_cmd_async_ok (c))
> + if (target_can_async_p ()
> + && target_has_execution
> + && any_running ()
> + && !get_cmd_async_ok (c))
> error (_("Cannot execute this command while the target is running."));
>
> /* Pass null arg rather than an empty one. */
Don't need target_has_execution here anymore, do we?
The patch otherwise looks OK.
Before we start checking these in, how do you plan to handle
documentation (internals also, but mostly user) and test cases?
I'd like to know there's at least a plan for this before we merge
non-stop.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-06-23 1:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-15 21:04 Pedro Alves
2008-06-15 22:18 ` Eli Zaretskii
2008-06-16 1:42 ` Daniel Jacobowitz
2008-06-16 3:23 ` Eli Zaretskii
2008-06-16 6:45 ` ChangeLog entries [was Re: [non-stop] 01/10 Add "executing" property] Nick Roberts
2008-06-16 7:22 ` [non-stop] 01/10 Add "executing" property Vladimir Prus
2008-06-17 0:40 ` Eli Zaretskii
2008-06-17 17:10 ` Vladimir Prus
2008-06-17 20:38 ` Eli Zaretskii
2008-06-23 17:27 ` Tom Tromey
2008-06-17 16:14 ` Joel Brobecker
2008-06-17 18:24 ` Eli Zaretskii
2008-06-17 18:32 ` Joel Brobecker
2008-06-18 0:22 ` Eli Zaretskii
2008-06-17 18:34 ` Pedro Alves
2008-06-17 20:58 ` Eli Zaretskii
2008-06-23 1:13 ` Daniel Jacobowitz [this message]
2008-06-23 11:54 ` Vladimir Prus
2008-06-23 14:41 ` Pedro Alves
2008-06-23 18:22 ` Eli Zaretskii
2008-06-23 18:25 ` Vladimir Prus
2008-06-23 19:52 ` Pedro Alves
2008-06-24 1:13 ` Eli Zaretskii
2008-06-23 18:14 ` Eli Zaretskii
2008-07-02 3:29 ` Pedro Alves
2008-06-25 19:02 ` Vladimir Prus
2008-06-25 19:13 ` Pedro Alves
2008-06-25 19:22 ` Daniel Jacobowitz
2008-06-26 13:37 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080623010353.GA23201@caradoc.them.org \
--to=drow@false.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox