From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4861 invoked by alias); 23 Jun 2008 01:04:16 -0000 Received: (qmail 4755 invoked by uid 22791); 23 Jun 2008 01:04:16 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 23 Jun 2008 01:03:56 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 85E8B98411; Mon, 23 Jun 2008 01:03:54 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 3356C98401; Mon, 23 Jun 2008 01:03:54 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KAaTJ-00011R-IR; Sun, 22 Jun 2008 21:03:53 -0400 Date: Mon, 23 Jun 2008 01:13:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org, Eli Zaretskii Subject: Re: [non-stop] 01/10 Add "executing" property Message-ID: <20080623010353.GA23201@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org, Eli Zaretskii References: <200806152203.14626.pedro@codesourcery.com> <20080617055354.GA3803@adacore.com> <200806171924.04486.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200806171924.04486.pedro@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00372.txt.bz2 On Tue, Jun 17, 2008 at 07:24:04PM +0100, Pedro Alves wrote: > @@ -422,7 +417,10 @@ execute_command (char *p, int from_tty) > > /* If the target is running, we allow only a limited set of > commands. */ > - if (target_can_async_p () && target_executing && !get_cmd_async_ok (c)) > + if (target_can_async_p () > + && target_has_execution > + && any_running () > + && !get_cmd_async_ok (c)) > error (_("Cannot execute this command while the target is running.")); > > /* Pass null arg rather than an empty one. */ Don't need target_has_execution here anymore, do we? The patch otherwise looks OK. Before we start checking these in, how do you plan to handle documentation (internals also, but mostly user) and test cases? I'd like to know there's at least a plan for this before we merge non-stop. -- Daniel Jacobowitz CodeSourcery