From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [non-stop] 01/10 Add "executing" property
Date: Tue, 17 Jun 2008 20:38:00 -0000 [thread overview]
Message-ID: <uy753hq0u.fsf@gnu.org> (raw)
In-Reply-To: <g381dl$9od$1@ger.gmane.org>
> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Tue, 17 Jun 2008 13:50:45 +0400
>
> Eli Zaretskii wrote:
>
> >> From: Vladimir Prus <vladimir@codesourcery.com>
> >> Date: Mon, 16 Jun 2008 10:42:09 +0400
> >>
> >> It's actually fairly weird that one has to maintain dependencies by hand,
> >
> > We are obviously miscommunicating. What I meant was simple entries
> > like:
> >
> > * Makefile.in (foo.o): Add bar.c and bar.h to prerequisites.
> > or
> > * Makefile.in (foo.o): Remove foobar.h from prerequisites.
> >
> > That's a far cry from ``maintaining dependencies by hand''.
>
> In fact, it is the same. Why do we, in 2008, need to add 'bar.h' to dependencies of
> foo.o?
I didn't say we needed to, I said that if we do, we should mention it
in the ChangeLog, that's all. The simple fact is that in this
particular case, the change was to add $(gdbthread_h) to the list of
prerequisites of several targets, like this:
inf-loop.o: inf-loop.c $(defs_h) $(inferior_h) $(target_h) $(event_loop_h) \
$(event_top_h) $(inf_loop_h) $(remote_h) $(exceptions_h) \
- $(language_h)
+ $(language_h) $(gdbthread_h)
If you think this kind of change is ``laughable'' in the year 2008,
please complain to Pedro, who suggested such a change; I didn't.
> That's painful and, honestly, laughable at, thing.
Well, entries such as "Makefile.in (event-top.o): Update." are no less
laughable, because they convey exactly zero useful information beyond
what "cvs log Makefile.in" already tells. If we want to accept such
entries, why don't we abandon ChangeLog files at all?
By contrast, saying _what_ was changed in the rules of a target gives
me valuable information that is a pain to glean from CVS, unless I'm
interested in the very last change, or know exactly in what version
the change I'm interested in was committed.
That said, I'm no longer young enough to fight Quixotic battles. If
this is the kind of coding standards the other GDB maintainers want to
adhere to, let's codify them somewhere, and be done with that, so that
I will never again need to start arguments like this one just to be
predictably voted down.
next prev parent reply other threads:[~2008-06-17 18:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-15 21:04 Pedro Alves
2008-06-15 22:18 ` Eli Zaretskii
2008-06-16 1:42 ` Daniel Jacobowitz
2008-06-16 3:23 ` Eli Zaretskii
2008-06-16 6:45 ` ChangeLog entries [was Re: [non-stop] 01/10 Add "executing" property] Nick Roberts
2008-06-16 7:22 ` [non-stop] 01/10 Add "executing" property Vladimir Prus
2008-06-17 0:40 ` Eli Zaretskii
2008-06-17 17:10 ` Vladimir Prus
2008-06-17 20:38 ` Eli Zaretskii [this message]
2008-06-23 17:27 ` Tom Tromey
2008-06-17 16:14 ` Joel Brobecker
2008-06-17 18:24 ` Eli Zaretskii
2008-06-17 18:32 ` Joel Brobecker
2008-06-18 0:22 ` Eli Zaretskii
2008-06-17 18:34 ` Pedro Alves
2008-06-17 20:58 ` Eli Zaretskii
2008-06-23 1:13 ` Daniel Jacobowitz
2008-06-23 11:54 ` Vladimir Prus
2008-06-23 14:41 ` Pedro Alves
2008-06-23 18:22 ` Eli Zaretskii
2008-06-23 18:25 ` Vladimir Prus
2008-06-23 19:52 ` Pedro Alves
2008-06-24 1:13 ` Eli Zaretskii
2008-06-23 18:14 ` Eli Zaretskii
2008-07-02 3:29 ` Pedro Alves
2008-06-25 19:02 ` Vladimir Prus
2008-06-25 19:13 ` Pedro Alves
2008-06-25 19:22 ` Daniel Jacobowitz
2008-06-26 13:37 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uy753hq0u.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox