* [PATCH/m68k] Fix incorrect test
@ 2008-05-23 5:44 Roman Zippel
2008-05-29 11:58 ` Daniel Jacobowitz
0 siblings, 1 reply; 2+ messages in thread
From: Roman Zippel @ 2008-05-23 5:44 UTC (permalink / raw)
To: gdb-patches
Hi,
The test in m68k_linux_pc_in_sigtramp() is inverted, causing gdb not
recognize the signal frame.
bye, Roman
2008-05-22 Roman Zippel <zippel@linux-m68k.org>
* m68klinux-tdep.c (m68k_linux_pc_in_sigtramp): Fix incorrect test.
Index: m68klinux-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/m68klinux-tdep.c,v
retrieving revision 1.29
diff -u -r1.29 m68klinux-tdep.c
--- m68klinux-tdep.c 5 May 2008 20:47:02 -0000 1.29
+++ m68klinux-tdep.c 22 May 2008 18:26:53 -0000
@@ -70,7 +70,7 @@
unsigned long insn0, insn1, insn2;
CORE_ADDR pc = get_frame_pc (this_frame);
- if (safe_frame_unwind_memory (this_frame, pc - 4, buf, sizeof (buf)))
+ if (!safe_frame_unwind_memory (this_frame, pc - 4, buf, sizeof (buf)))
return 0;
insn1 = extract_unsigned_integer (buf + 4, 4);
insn2 = extract_unsigned_integer (buf + 8, 4);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH/m68k] Fix incorrect test
2008-05-23 5:44 [PATCH/m68k] Fix incorrect test Roman Zippel
@ 2008-05-29 11:58 ` Daniel Jacobowitz
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Jacobowitz @ 2008-05-29 11:58 UTC (permalink / raw)
To: Roman Zippel; +Cc: gdb-patches
On Thu, May 22, 2008 at 08:45:02PM +0200, Roman Zippel wrote:
> Hi,
>
> The test in m68k_linux_pc_in_sigtramp() is inverted, causing gdb not
> recognize the signal frame.
>
> bye, Roman
>
> 2008-05-22 Roman Zippel <zippel@linux-m68k.org>
>
> * m68klinux-tdep.c (m68k_linux_pc_in_sigtramp): Fix incorrect test.
Also OK, thanks.
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-28 21:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-05-23 5:44 [PATCH/m68k] Fix incorrect test Roman Zippel
2008-05-29 11:58 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox