From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28964 invoked by alias); 22 May 2008 18:45:24 -0000 Received: (qmail 28956 invoked by uid 22791); 22 May 2008 18:45:23 -0000 X-Spam-Check-By: sourceware.org Received: from linux-m68k.xs4all.nl (HELO scrub.xs4all.nl) (82.95.193.92) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 22 May 2008 18:45:05 +0000 Received: from roman (helo=localhost) by scrub.xs4all.nl with local-esmtp (Exim 3.36 #1 (Debian)) id 1JzFmg-0005K9-00 for ; Thu, 22 May 2008 20:45:02 +0200 Date: Fri, 23 May 2008 05:44:00 -0000 From: Roman Zippel To: gdb-patches@sourceware.org Subject: [PATCH/m68k] Fix incorrect test Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00670.txt.bz2 Hi, The test in m68k_linux_pc_in_sigtramp() is inverted, causing gdb not recognize the signal frame. bye, Roman 2008-05-22 Roman Zippel * m68klinux-tdep.c (m68k_linux_pc_in_sigtramp): Fix incorrect test. Index: m68klinux-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/m68klinux-tdep.c,v retrieving revision 1.29 diff -u -r1.29 m68klinux-tdep.c --- m68klinux-tdep.c 5 May 2008 20:47:02 -0000 1.29 +++ m68klinux-tdep.c 22 May 2008 18:26:53 -0000 @@ -70,7 +70,7 @@ unsigned long insn0, insn1, insn2; CORE_ADDR pc = get_frame_pc (this_frame); - if (safe_frame_unwind_memory (this_frame, pc - 4, buf, sizeof (buf))) + if (!safe_frame_unwind_memory (this_frame, pc - 4, buf, sizeof (buf))) return 0; insn1 = extract_unsigned_integer (buf + 4, 4); insn2 = extract_unsigned_integer (buf + 8, 4);