Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Roman Zippel <zippel@linux-m68k.org>
To: gdb-patches@sourceware.org
Subject: [PATCH/m68k] Fix incorrect test
Date: Fri, 23 May 2008 05:44:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.64.0805222042300.20457@scrub.home> (raw)

Hi,

The test in m68k_linux_pc_in_sigtramp() is inverted, causing gdb not 
recognize the signal frame.

bye, Roman

2008-05-22  Roman Zippel <zippel@linux-m68k.org>

	* m68klinux-tdep.c (m68k_linux_pc_in_sigtramp): Fix incorrect test.

Index: m68klinux-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/m68klinux-tdep.c,v
retrieving revision 1.29
diff -u -r1.29 m68klinux-tdep.c
--- m68klinux-tdep.c	5 May 2008 20:47:02 -0000	1.29
+++ m68klinux-tdep.c	22 May 2008 18:26:53 -0000
@@ -70,7 +70,7 @@
   unsigned long insn0, insn1, insn2;
   CORE_ADDR pc = get_frame_pc (this_frame);
 
-  if (safe_frame_unwind_memory (this_frame, pc - 4, buf, sizeof (buf)))
+  if (!safe_frame_unwind_memory (this_frame, pc - 4, buf, sizeof (buf)))
     return 0;
   insn1 = extract_unsigned_integer (buf + 4, 4);
   insn2 = extract_unsigned_integer (buf + 8, 4);


             reply	other threads:[~2008-05-22 18:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-23  5:44 Roman Zippel [this message]
2008-05-29 11:58 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0805222042300.20457@scrub.home \
    --to=zippel@linux-m68k.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox