Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: drow@false.org (Daniel Jacobowitz)
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Relax "printf" function name check in annota* test cases
Date: Thu, 15 May 2008 00:54:00 -0000	[thread overview]
Message-ID: <200805142245.m4EMjopF021777@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20080514220055.GA27367@caradoc.them.org> from "Daniel Jacobowitz" at May 14, 2008 06:00:55 PM

Daniel Jacobowitz wrote:
> On Wed, May 14, 2008 at 11:36:22PM +0200, Ulrich Weigand wrote:
> > Hello,
> > 
> > this patch fixes the last regression after Alan's patch was applied:
> > some sub-tests of annota1.exp and annota3.exp are now failing because
> > when stopped at the "printf" breakpoint, the current function is not
> > called printf, but printf@plt.
> 
> This is unrelated to the annota tests, as you said... but the
> breakpoint is at "printf", isn't it?  Why are we stopping at
> printf@plt instead of the definition when we know glibc is loaded?
> 
> Maybe this comes back to the two names trouble?

No, this is the symbol versioning problem; we do not find any exported
symbol named "printf" in glibc, and so the breakpoint remains on the
plt stub.

Note that before Alan's patch the breakpoint *also* remained on the
plt stub, it's just that the stub was then called "printf" (the solib
trampoline generated from the undefined symbol), not "printf@plt"
(from the synthetic symbol).

B.t.w. even if we were to handle versioned symbols (I have a patch
for that), the original annota test cases would still break -- 
because the function would then be called printf@GLIBC...

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2008-05-14 22:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-15  0:37 Ulrich Weigand
2008-05-15  0:45 ` Daniel Jacobowitz
2008-05-15  0:54   ` Ulrich Weigand [this message]
2008-05-15 12:09     ` Daniel Jacobowitz
2008-05-16 15:27       ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805142245.m4EMjopF021777@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox