From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32608 invoked by alias); 14 May 2008 22:46:16 -0000 Received: (qmail 32600 invoked by uid 22791); 14 May 2008 22:46:15 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 14 May 2008 22:45:54 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id m4EMjp9J336480 for ; Wed, 14 May 2008 22:45:51 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m4EMjpx12777270 for ; Thu, 15 May 2008 00:45:51 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m4EMjo7Z021780 for ; Thu, 15 May 2008 00:45:50 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m4EMjopF021777; Thu, 15 May 2008 00:45:50 +0200 Message-Id: <200805142245.m4EMjopF021777@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 15 May 2008 00:45:50 +0200 Subject: Re: [rfc] Relax "printf" function name check in annota* test cases To: drow@false.org (Daniel Jacobowitz) Date: Thu, 15 May 2008 00:54:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20080514220055.GA27367@caradoc.them.org> from "Daniel Jacobowitz" at May 14, 2008 06:00:55 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00452.txt.bz2 Daniel Jacobowitz wrote: > On Wed, May 14, 2008 at 11:36:22PM +0200, Ulrich Weigand wrote: > > Hello, > > > > this patch fixes the last regression after Alan's patch was applied: > > some sub-tests of annota1.exp and annota3.exp are now failing because > > when stopped at the "printf" breakpoint, the current function is not > > called printf, but printf@plt. > > This is unrelated to the annota tests, as you said... but the > breakpoint is at "printf", isn't it? Why are we stopping at > printf@plt instead of the definition when we know glibc is loaded? > > Maybe this comes back to the two names trouble? No, this is the symbol versioning problem; we do not find any exported symbol named "printf" in glibc, and so the breakpoint remains on the plt stub. Note that before Alan's patch the breakpoint *also* remained on the plt stub, it's just that the stub was then called "printf" (the solib trampoline generated from the undefined symbol), not "printf@plt" (from the synthetic symbol). B.t.w. even if we were to handle versioned symbols (I have a patch for that), the original annota test cases would still break -- because the function would then be called printf@GLIBC... Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com