From: Joel Brobecker <brobecker@adacore.com>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] New annotation for threads
Date: Tue, 29 Apr 2008 04:47:00 -0000 [thread overview]
Message-ID: <20080429023735.GD841@adacore.com> (raw)
In-Reply-To: <18440.29531.916381.569346@kahikatea.snap.net.nz>
> This is just an annotation equivalent of Vladimir's patch for an observer
> for new threads.
I'd really like to have others' opinions on this one. I thought that
we weren't going to change our annotations anymore. And even though
we were not going to remove annotations for a while longer, we were
going to focuse on MI instead.
The change is sufficiently small that I'm thinking, why not, but can't
approve the suggestion just by myself.
Regarding the code itself:
> 2008-04-18 Nick Roberts <nickrob@snap.net.nz>
>
> * annotate.h: (annotate_new_thread): New extern.
>
> * annotate.c (annotate_new_thread): New function.
>
> * thread.c (add_thread_with_info): Use it.
How about creating a new observer for new_threads events instead of
specifically calling an annotation function from "add_thread"? Seems
much cleaner that way.
--
Joel
next prev parent reply other threads:[~2008-04-29 2:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 16:06 Nick Roberts
2008-04-29 4:47 ` Joel Brobecker [this message]
2008-04-29 14:19 ` Nick Roberts
2008-05-01 18:18 ` Joel Brobecker
2008-05-01 18:44 ` Daniel Jacobowitz
2008-05-01 23:31 ` Nick Roberts
2008-05-01 23:37 ` Joel Brobecker
2008-05-02 0:07 ` Nick Roberts
2008-05-02 5:50 ` Joel Brobecker
2008-05-02 10:41 ` Eli Zaretskii
2008-05-17 15:51 ` Nick Roberts
2008-05-17 19:15 ` Stan Shebs
2008-05-17 21:18 ` Eli Zaretskii
2008-05-18 3:20 ` Bob Rossi
2008-05-18 9:11 ` Bob Rossi
2008-05-18 17:44 ` Eli Zaretskii
2008-05-19 8:48 ` Joel Brobecker
2008-05-19 9:09 ` Nick Roberts
2008-05-19 9:44 ` Eli Zaretskii
2008-05-19 12:39 ` Nick Roberts
2008-05-19 13:23 ` Eli Zaretskii
2008-05-20 15:27 ` Joel Brobecker
2008-05-20 16:10 ` Nick Roberts
2008-05-20 16:43 ` Nick Roberts
2008-05-20 18:09 ` Joel Brobecker
2008-05-21 3:55 ` Nick Roberts
2008-05-21 7:22 ` Joel Brobecker
2008-05-20 22:21 ` Eli Zaretskii
2008-05-20 22:54 ` Joel Brobecker
2008-05-21 3:26 ` Eli Zaretskii
2008-05-21 9:33 ` Joel Brobecker
2008-05-21 15:11 ` Nick Roberts
2008-05-21 15:14 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080429023735.GD841@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox