From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17278 invoked by alias); 29 Apr 2008 02:38:04 -0000 Received: (qmail 17266 invoked by uid 22791); 29 Apr 2008 02:38:03 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 29 Apr 2008 02:37:40 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8B45C2A97D9; Mon, 28 Apr 2008 22:37:38 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id XXSHZjfgyr7U; Mon, 28 Apr 2008 22:37:38 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 481212A97D5; Mon, 28 Apr 2008 22:37:37 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 7079AE7ACD; Mon, 28 Apr 2008 19:37:35 -0700 (PDT) Date: Tue, 29 Apr 2008 04:47:00 -0000 From: Joel Brobecker To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] New annotation for threads Message-ID: <20080429023735.GD841@adacore.com> References: <18440.29531.916381.569346@kahikatea.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18440.29531.916381.569346@kahikatea.snap.net.nz> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00647.txt.bz2 > This is just an annotation equivalent of Vladimir's patch for an observer > for new threads. I'd really like to have others' opinions on this one. I thought that we weren't going to change our annotations anymore. And even though we were not going to remove annotations for a while longer, we were going to focuse on MI instead. The change is sufficiently small that I'm thinking, why not, but can't approve the suggestion just by myself. Regarding the code itself: > 2008-04-18 Nick Roberts > > * annotate.h: (annotate_new_thread): New extern. > > * annotate.c (annotate_new_thread): New function. > > * thread.c (add_thread_with_info): Use it. How about creating a new observer for new_threads events instead of specifically calling an annotation function from "add_thread"? Seems much cleaner that way. -- Joel