Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: nickrob@snap.net.nz, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] New annotation for threads
Date: Wed, 21 May 2008 09:33:00 -0000	[thread overview]
Message-ID: <20080521033025.GB4080@adacore.com> (raw)
In-Reply-To: <uve18hkri.fsf@gnu.org>

> > | Separate unrelated change log entries with blank lines. When two entries
> > | represent parts of the same change, so that they work together, then
> > | don't put blank lines between them. Then you can omit the file name and
> > | the asterisk when successive entries are in the same file.
> 
> That's extra manual work that we shouldn't insist on.  If several
> entries represent a single changeset, one can precede them with a
> single sentence saying what is the change about.

Traditionally, we have followed the advice of the GNU Coding standards
and not used the empty line when the changes were inter-related. I
personally find that this makes the entry more readable, and I suspect
that this was the reason behind the suggestion in the GCS - I can accept
however that this is a matter of taste and also probably habit as well.
But I think that asking someone to follow this rule is reasonable given
the little amount of extra work that it requires. I would also suggest
that emacs be fixed to follow the GCS.

That being said, I'm not going to argue pro or against what you suggest.
I am ok with the deviation if the other maintainers are.

But in the meantime, I have to continue to make sure that contributions
meet the GCS.

-- 
Joel


  reply	other threads:[~2008-05-21  3:30 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-18 16:06 Nick Roberts
2008-04-29  4:47 ` Joel Brobecker
2008-04-29 14:19   ` Nick Roberts
2008-05-01 18:18     ` Joel Brobecker
2008-05-01 18:44       ` Daniel Jacobowitz
2008-05-01 23:31       ` Nick Roberts
2008-05-01 23:37         ` Joel Brobecker
2008-05-02  0:07           ` Nick Roberts
2008-05-02  5:50             ` Joel Brobecker
2008-05-02 10:41             ` Eli Zaretskii
2008-05-17 15:51               ` Nick Roberts
2008-05-17 19:15                 ` Stan Shebs
2008-05-17 21:18                 ` Eli Zaretskii
2008-05-18  3:20                   ` Bob Rossi
2008-05-18  9:11                     ` Bob Rossi
2008-05-18 17:44                     ` Eli Zaretskii
2008-05-19  8:48                       ` Joel Brobecker
2008-05-19  9:09                   ` Nick Roberts
2008-05-19  9:44                     ` Eli Zaretskii
2008-05-19 12:39                 ` Nick Roberts
2008-05-19 13:23                   ` Eli Zaretskii
2008-05-20 15:27                   ` Joel Brobecker
2008-05-20 16:10                     ` Nick Roberts
2008-05-20 16:43                       ` Nick Roberts
2008-05-20 18:09                         ` Joel Brobecker
2008-05-21  3:55                           ` Nick Roberts
2008-05-21  7:22                             ` Joel Brobecker
2008-05-20 22:21                     ` Eli Zaretskii
2008-05-20 22:54                       ` Joel Brobecker
2008-05-21  3:26                         ` Eli Zaretskii
2008-05-21  9:33                           ` Joel Brobecker [this message]
2008-05-21 15:11                             ` Nick Roberts
2008-05-21 15:14                               ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080521033025.GB4080@adacore.com \
    --to=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox