Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Andreas Schwab <schwab@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc, rfa/doc] Multi-threaded watchpoint improvements
Date: Thu, 17 Apr 2008 00:25:00 -0000	[thread overview]
Message-ID: <20080416231831.GB6274@caradoc.them.org> (raw)
In-Reply-To: <jeabjtcsfb.fsf@sykes.suse.de>

On Thu, Apr 17, 2008 at 01:04:56AM +0200, Andreas Schwab wrote:
> infrun: infwait_nonstep_watch_state
> infrun: TARGET_WAITKIND_STOPPED
> infrun: stop_pc = 0x100004b0
> infrun: random signal 5

Thanks, I can see the problem.  stepped_after_stopped_by_watchpoint is
set, but nothing is using that to indicate that we should report the
watchpoint.

We need to communicate this to bpstat_stop_status again after the
step.  It's supposed to happen automatically, because only a call to
watchpoints_triggered ever clears the watchpoint_triggered flag.
How is it getting lost?  I assume that it is getting lost; you
could set a breakpoint on bpstat_stop_status when it is called
just before the "random signal 5", after infwait_nonstep_watch_state,
and check.

I wonder if this could be related to Vladimir's changes to watchpoint
locations.  No, the flag is on struct breakpoint, not struct
bp_location.  I'm mystified.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2008-04-16 23:18 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-16 18:40 Daniel Jacobowitz
2007-09-22  9:03 ` Eli Zaretskii
2007-09-22 14:04   ` Daniel Jacobowitz
2007-09-22 14:13     ` Eli Zaretskii
2007-09-22 15:37       ` Daniel Jacobowitz
2007-09-22 15:46         ` Eli Zaretskii
2007-09-22 18:28           ` Daniel Jacobowitz
2007-10-01  0:20 ` Daniel Jacobowitz
2007-10-24 14:59   ` Luis Machado
2007-10-24 16:00     ` Daniel Jacobowitz
2007-10-24 16:42       ` Luis Machado
2007-10-24 16:51         ` Daniel Jacobowitz
2007-10-24 18:08           ` Luis Machado
2007-10-24 18:20             ` Daniel Jacobowitz
2008-04-16 22:57   ` Andreas Schwab
2008-04-16 23:05     ` Daniel Jacobowitz
2008-04-16 23:18       ` Andreas Schwab
2008-04-17  0:25         ` Daniel Jacobowitz [this message]
2008-04-17  9:52           ` Andreas Schwab
2008-04-17  9:59             ` Andreas Schwab
2008-04-17 10:17           ` Andreas Schwab
2008-04-17 14:53             ` Daniel Jacobowitz
2008-04-20  2:35               ` Andreas Schwab
2008-04-23 11:55                 ` Andreas Schwab
2008-04-23 19:46                   ` Eli Zaretskii
2008-05-01 19:30                   ` Daniel Jacobowitz
2008-05-01 19:50       ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080416231831.GB6274@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox