From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4383 invoked by alias); 16 Apr 2008 23:18:56 -0000 Received: (qmail 4362 invoked by uid 22791); 16 Apr 2008 23:18:54 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 16 Apr 2008 23:18:33 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 465D7982C4; Wed, 16 Apr 2008 23:18:32 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 0F39098278; Wed, 16 Apr 2008 23:18:32 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JmGtb-0001ve-9Y; Wed, 16 Apr 2008 19:18:31 -0400 Date: Thu, 17 Apr 2008 00:25:00 -0000 From: Daniel Jacobowitz To: Andreas Schwab Cc: gdb-patches@sourceware.org Subject: Re: [rfc, rfa/doc] Multi-threaded watchpoint improvements Message-ID: <20080416231831.GB6274@caradoc.them.org> Mail-Followup-To: Andreas Schwab , gdb-patches@sourceware.org References: <20070916183949.GA23966@caradoc.them.org> <20071001002015.GA15835@caradoc.them.org> <20080416224910.GA3716@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00320.txt.bz2 On Thu, Apr 17, 2008 at 01:04:56AM +0200, Andreas Schwab wrote: > infrun: infwait_nonstep_watch_state > infrun: TARGET_WAITKIND_STOPPED > infrun: stop_pc = 0x100004b0 > infrun: random signal 5 Thanks, I can see the problem. stepped_after_stopped_by_watchpoint is set, but nothing is using that to indicate that we should report the watchpoint. We need to communicate this to bpstat_stop_status again after the step. It's supposed to happen automatically, because only a call to watchpoints_triggered ever clears the watchpoint_triggered flag. How is it getting lost? I assume that it is getting lost; you could set a breakpoint on bpstat_stop_status when it is called just before the "random signal 5", after infwait_nonstep_watch_state, and check. I wonder if this could be related to Vladimir's changes to watchpoint locations. No, the flag is on struct breakpoint, not struct bp_location. I'm mystified. -- Daniel Jacobowitz CodeSourcery