* [RFA] Add dwarf to last_source_file comment.
@ 2008-04-05 9:11 Doug Evans
2008-04-05 9:29 ` Daniel Jacobowitz
0 siblings, 1 reply; 2+ messages in thread
From: Doug Evans @ 2008-04-05 9:11 UTC (permalink / raw)
To: gdb-patches
Ok to check in?
2008-04-04 Doug Evans <dje@google.com>
* buildsym.h (last_source_file): Add dwarf info to comment.
(last_source_start_addr): Ditto.
Index: buildsym.h
===================================================================
RCS file: /cvs/src/src/gdb/buildsym.h,v
retrieving revision 1.20
diff -u -p -u -p -r1.20 buildsym.h
--- buildsym.h 1 Jan 2008 22:53:09 -0000 1.20
+++ buildsym.h 4 Apr 2008 23:07:20 -0000
@@ -47,12 +47,14 @@ struct block;
hashname() */
/* Name of source file whose symbol data we are now processing. This
- comes from a symbol of type N_SO. */
+ comes from a symbol of type N_SO for stabs. For Dwarf it comes from the
+ DW_AT_name attribute of a DW_TAG_compile_unit DIE. */
EXTERN char *last_source_file;
/* Core address of start of text of current source file. This too
- comes from the N_SO symbol. */
+ comes from the N_SO symbol. For Dwarf it typically comes from the
+ DW_AT_low_pc attribute of a DW_TAG_compile_unit DIE. */
EXTERN CORE_ADDR last_source_start_addr;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFA] Add dwarf to last_source_file comment.
2008-04-05 9:11 [RFA] Add dwarf to last_source_file comment Doug Evans
@ 2008-04-05 9:29 ` Daniel Jacobowitz
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Jacobowitz @ 2008-04-05 9:29 UTC (permalink / raw)
To: Doug Evans; +Cc: gdb-patches
On Fri, Apr 04, 2008 at 04:08:16PM -0700, Doug Evans wrote:
> Ok to check in?
>
> 2008-04-04 Doug Evans <dje@google.com>
>
> * buildsym.h (last_source_file): Add dwarf info to comment.
> (last_source_start_addr): Ditto.
OK, thanks.
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-05 2:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-05 9:11 [RFA] Add dwarf to last_source_file comment Doug Evans
2008-04-05 9:29 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox